[#73] Uploader, downloader structures refactoring #79

mbiryukova · 2023-08-31T11:15:14Z

mbiryukova commented

2023-08-31 11:15:14 +00:00

Closes #73

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #73 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova self-assigned this 2023-08-31 11:15:14 +00:00

mbiryukova force-pushed feature/uploader_downloader_refactor from e87d7939e3 to cbd95ddbcf

2023-08-31 11:29:41 +00:00

Compare

mbiryukova force-pushed feature/uploader_downloader_refactor from cbd95ddbcf to a2a0ee8946

2023-08-31 11:54:37 +00:00

Compare

mbiryukova requested review from storage-services-committers 2023-08-31 12:04:22 +00:00

mbiryukova requested review from storage-services-developers 2023-08-31 12:04:24 +00:00

mbiryukova force-pushed feature/uploader_downloader_refactor from a2a0ee8946 to 665dce78b1

2023-08-31 12:44:27 +00:00

Compare

dkirillov reviewed 2023-09-01 12:55:32 +00:00

dkirillov left a comment

Probable we can keep all handler's methods related to upload in handler/upload.go and methods for download in handler/download.go.

Everything else looks good

Probable we can keep all handler's methods related to upload in `handler/upload.go` and methods for download in `handler/download.go`. Everything else looks good

handler/handler.go Outdated

					
				@ -0,0 +1,558 @@

				package handler

dkirillov commented

2023-09-01 12:51:11 +00:00

Probably we should move the handler package to internal directory.

The same for api package

Probably we should move the `handler` package to `internal` directory. The same for `api` package

alexvanin commented

2023-09-07 11:29:05 +00:00

Well, this is opinionated, but let's keep it. There is no wrong or right answer for this kind of layout.

handler/handler.go Outdated

					
				@ -0,0 +67,4 @@

				// Settings stores reloading parameters, so it has to provide atomic getters and setters.

				type Settings struct {

					defaultTimestamp atomic.Bool

					zipCompression   atomic.Bool

dkirillov commented

2023-09-01 12:46:05 +00:00

I would use interface here instead of struct. But let's update it in #74

I would use interface here instead of struct. But let's update it in https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/issues/74

handler/reader.go Outdated

					
				@ -0,0 +48,4 @@

					return http.DetectContentType(buf), buf, err // to not lose io.EOF

				}

				func receiveFile(ctx context.Context, req request, clnt *pool.Pool, objectAddress oid.Address) {

dkirillov commented

2023-09-01 12:49:38 +00:00

It seems we can use

func (h *Handler) receiveFile(ctx context.Context, req request, objectAddress oid.Address) {

the same for headObject.

The functions like Handler.byAttribute will have the following signature then

func (h *Handler) byAttribute(c *fasthttp.RequestCtx, f func(context.Context, request, oid.Address)) {

It seems we can use ```golang func (h *Handler) receiveFile(ctx context.Context, req request, objectAddress oid.Address) { ``` the same for `headObject`. The functions like `Handler.byAttribute` will have the following signature then ```golang func (h *Handler) byAttribute(c *fasthttp.RequestCtx, f func(context.Context, request, oid.Address)) { ```