TrueCloudLab/frostfs-locode-db
15
0
Fork 9
Code Issues 5 Pull requests 1 Releases 1 Activity

Add missing locode details using overrides #21

Merged
fyrchik merged 3 commits from aarifullin/frostfs-locode-db:fix/missing_locodes into master 2025-02-05 11:19:33 +00:00
Conversation 0 Commits 3 Files changed 7 +21578 -23
aarifullin commented 2025-01-22 19:10:03 +00:00
Member
Copy link
  1. Introduce UN/LOCODE overrides and copy it by the recipe:
  • Introduce unlocode-CodeList_overrides.csv that contains missing details for locodes from the main unlocode-CodeList.csv file;
  • Fix Makefile
  • Add info to README.md.
  1. Introduce locode overriding
  2. Count ignored and added records to result locode db
1. Introduce UN/LOCODE overrides and copy it by the recipe: * Introduce `unlocode-CodeList_overrides.csv` that contains missing details for locodes from the main `unlocode-CodeList.csv` file; * Fix `Makefile` * Add info to `README.md`. 2. Introduce locode overriding 3. Count ignored and added records to result locode db
aarifullin added 3 commits 2025-01-22 19:10:04 +00:00 
* Introduce `unlocode-CodeList_overrides.csv` that contains missing details
 for locodes from the main `unlocode-CodeList.csv` file;
* Fix `Makefile`;
* Add info to `README.md`.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
requested reviews from realloc, fyrchik, a.bogatyrev, alexvanin 2025-01-22 19:10:04 +00:00
aarifullin force-pushed fix/missing_locodes from bb24081e7c to 655808ca0a 2025-01-22 19:10:55 +00:00 Compare
acid-ant approved these changes 2025-01-23 06:33:36 +00:00
Dismissed
dstepanov-yadro approved these changes 2025-01-27 08:05:42 +00:00
Dismissed
dstepanov-yadro approved these changes 2025-01-27 08:07:37 +00:00
Dismissed
fyrchik reviewed 2025-01-27 08:47:28 +00:00
pkg/locode/db/db.go Outdated
@ -89,2 +106,3 @@
})
return errG.Wait()
err := errG.Wait()
fyrchik commented 2025-01-27 08:45:15 +00:00
Owner
Copy link

This is unnecessary, might as well return ..., errG.Wait()

This is unnecessary, might as well `return ..., errG.Wait()`
aarifullin commented 2025-01-31 12:51:23 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
pkg/locode/table/csv/calls.go Outdated
@ -106,0 +123,4 @@
func (t *Table) initOverrides() (err error) {
const wordsPerRecord = 12
t.overridesOnce.Do(func() {
fyrchik commented 2025-01-27 08:46:42 +00:00
Owner
Copy link

Do we need to use once?
Can we initialize it once during setup stage in a single thread?

Do we need to use `once`? Can we initialize it once during setup stage in a single thread?
aarifullin commented 2025-01-31 12:51:49 +00:00
Author
Member
Copy link

Do we need to use once?

We don't, for sure. Fixed

> Do we need to use once? We don't, for sure. Fixed
fyrchik marked this conversation as resolved
aarifullin force-pushed fix/missing_locodes from 655808ca0a to f35b1c62e8 2025-01-31 12:45:34 +00:00 Compare
aarifullin dismissed acid-ant's review 2025-01-31 12:45:34 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aarifullin dismissed dstepanov-yadro's review 2025-01-31 12:45:34 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro approved these changes 2025-02-04 15:33:07 +00:00
fyrchik approved these changes 2025-02-05 11:19:28 +00:00
fyrchik merged commit f35b1c62e8 into master 2025-02-05 11:19:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
realloc
a.bogatyrev
alexvanin
dstepanov-yadro
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-locode-db#21
No description provided.
Delete branch "aarifullin/frostfs-locode-db:fix/missing_locodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?