TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 8 Projects Releases 1 Activity Actions

[#45] object/search: Add filtering parent objects

Browse source 
In previous implementation object.Search services allowed to search only
physically stored objects. This limitation did not allow getting the ID of
the split object.

Extend search execution logic with parent object filtering. Parent objects
that passed filters are now included in the result

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2020-09-28 18:11:11 +03:00 committed by Alex Vanin
parent 88459963fb
commit 08b9ae547a
1 changed files with 30 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
pkg/services/object/search/local.go
View file

@ -3,7 +3,8 @@ package searchsvc
import ( import (
"context" "context"
"github.com/nspcc-dev/neofs-api-go/pkg/object" objectSDK "github.com/nspcc-dev/neofs-api-go/pkg/object"
"github.com/nspcc-dev/neofs-node/pkg/core/object"
"github.com/nspcc-dev/neofs-node/pkg/local_object_storage/bucket" "github.com/nspcc-dev/neofs-node/pkg/local_object_storage/bucket"
"github.com/nspcc-dev/neofs-node/pkg/local_object_storage/localstore" "github.com/nspcc-dev/neofs-node/pkg/local_object_storage/localstore"
"github.com/nspcc-dev/neofs-node/pkg/services/object/search/query" "github.com/nspcc-dev/neofs-node/pkg/services/object/search/query"
@ -16,10 +17,23 @@ type localStream struct {
storage *localstore.Storage storage *localstore.Storage
} }
func (s *localStream) stream(ctx context.Context, ch chan<- []*object.ID) error { type searchQueryFilter struct {
idList := make([]*object.ID, 0) localstore.FilterPipeline
if err := s.storage.Iterate(newFilterPipeline(s.query), func(meta *localstore.ObjectMeta) bool { query query.Query
ch chan<- []*objectSDK.ID
}
func (s *localStream) stream(ctx context.Context, ch chan<- []*objectSDK.ID) error {
idList := make([]*objectSDK.ID, 0)
filter := &searchQueryFilter{
query: s.query,
ch: ch,
}
if err := s.storage.Iterate(filter, func(meta *localstore.ObjectMeta) bool {
select { select {
case <-ctx.Done(): case <-ctx.Done():
return true return true
@ -37,28 +51,19 @@ func (s *localStream) stream(ctx context.Context, ch chan<- []*object.ID) error
return nil return nil
} }
func newFilterPipeline(q query.Query) localstore.FilterPipeline { func (f *searchQueryFilter) Pass(ctx context.Context, meta *localstore.ObjectMeta) *localstore.FilterResult {
res := localstore.NewFilter(&localstore.FilterParams{ loop:
Name: "SEARCH_OBJECTS_FILTER", for obj := meta.Head(); obj.GetID() != nil; obj = object.NewFromSDK(obj.GetParent()) {
FilterFunc: func(context.Context, *localstore.ObjectMeta) *localstore.FilterResult { if !f.query.Match(obj) {
return localstore.ResultPass() continue
}, }
})
if err := res.PutSubFilter(localstore.SubFilterParams{ select {
FilterPipeline: localstore.NewFilter(&localstore.FilterParams{ case <-ctx.Done():
FilterFunc: func(_ context.Context, o *localstore.ObjectMeta) *localstore.FilterResult { break loop
if !q.Match(o.Head()) { case f.ch <- []*objectSDK.ID{obj.GetID()}:
return localstore.ResultFail() }
}
return localstore.ResultPass()
},
}),
OnIgnore: localstore.CodeFail,
OnFail: localstore.CodeFail,
}); err != nil {
panic(errors.Wrap(err, "could not create all pass including filter"))
} }
return res return localstore.ResultPass()
} }