TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

[#1522] adm/frostfsid: Remove unreachable condition
All checks were successful
DCO action / DCO (pull_request) Successful in 1m44s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m39s
Details
Build / Build Components (pull_request) Successful in 4m17s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m22s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m38s
Details
Tests and linters / gopls check (pull_request) Successful in 5m26s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m46s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m46s
Details
Tests and linters / Lint (pull_request) Successful in 6m58s
Details
Tests and linters / Tests (pull_request) Successful in 8m38s
Details

Browse source 
SendConsensusTx() modifies SendTxs field, if it is not the case, there
is a bug in code.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
This commit is contained in:
Evgenii Stratonikov 2024-11-22 13:19:58 +03:00
parent 8ccbf5a23a
commit 0f3ed39bf9
Signed by: fyrchik
SSH key fingerprint: SHA256:m/TTwCzjnRkXgnzEx9X92ccxy1CcVeinOgDb3NPWWmg
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cmd/frostfs-adm/internal/modules/morph/frostfsid/frostfsid.go
View file

@ -1,7 +1,6 @@
package frostfsid package frostfsid
import ( import (
"errors"
"fmt" "fmt"
"math/big" "math/big"
"sort" "sort"
@ -489,10 +488,6 @@ func (f *frostfsidClient) sendWaitRes() (*state.AppExecResult, error) {
} }
f.bw.Reset() f.bw.Reset()
if len(f.wCtx.SentTxs) == 0 {
return nil, errors.New("no transactions to wait")
}
f.wCtx.Command.Println("Waiting for transactions to persist...") f.wCtx.Command.Println("Waiting for transactions to persist...")
return f.roCli.Wait(f.wCtx.SentTxs[0].Hash, f.wCtx.SentTxs[0].Vub, nil) return f.roCli.Wait(f.wCtx.SentTxs[0].Hash, f.wCtx.SentTxs[0].Vub, nil)
} }