TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 96 Pull requests 4 Projects Releases 1 Activity Actions

[#649] shard/test: Increase GC remover interval
All checks were successful
DCO action / DCO (pull_request) Successful in 4m45s
Details
Vulncheck / Vulncheck (pull_request) Successful in 5m54s
Details
Build / Build Components (1.20) (pull_request) Successful in 7m13s
Details
Build / Build Components (1.21) (pull_request) Successful in 7m11s
Details
Tests and linters / Staticcheck (pull_request) Successful in 7m21s
Details
Tests and linters / Lint (pull_request) Successful in 7m43s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 9m39s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 21m43s
Details
Tests and linters / Tests with -race (pull_request) Successful in 22m33s
Details

Browse source 
This was set in #348 to speed up tests.
It seems 100ms doesn't increase overall test time,
but it reduces the amount of logs by 100x factor.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
This commit is contained in:
Evgenii Stratonikov 2023-08-25 12:04:34 +03:00
parent 1ced0e936f
commit 1f0b736137
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/local_object_storage/shard/delete_test.go
View file

@ -3,6 +3,7 @@ package shard_test
import (
"context"
"testing"
"time"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/core/object"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/internal/testutil"
@ -56,8 +57,10 @@ func testShardDelete(t *testing.T, hasWriteCache bool) {
_, err = sh.Delete(context.TODO(), delPrm)
require.NoError(t, err)
_, err = sh.Get(context.Background(), getPrm)
require.True(t, client.IsErrObjectNotFound(err))
require.Eventually(t, func() bool {
_, err = sh.Get(context.Background(), getPrm)
return client.IsErrObjectNotFound(err)
}, time.Second, 50*time.Millisecond)
})
t.Run("small object", func(t *testing.T) {
@ -80,7 +83,9 @@ func testShardDelete(t *testing.T, hasWriteCache bool) {
_, err = sh.Delete(context.Background(), delPrm)
require.NoError(t, err)
_, err = sh.Get(context.Background(), getPrm)
require.True(t, client.IsErrObjectNotFound(err))
require.Eventually(t, func() bool {
_, err = sh.Get(context.Background(), getPrm)
return client.IsErrObjectNotFound(err)
}, time.Second, 50*time.Millisecond)
})
}

2
pkg/local_object_storage/shard/shard_test.go
View file

@ -101,7 +101,7 @@ func newCustomShard(t testing.TB, rootPath string, enableWriteCache bool, wcOpts
require.NoError(t, err)
return pool
}),
shard.WithGCRemoverSleepInterval(1 * time.Millisecond),
shard.WithGCRemoverSleepInterval(100 * time.Millisecond),
}
sh = shard.New(opts...)