TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 109 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#1667] shard: Drop shard pool
All checks were successful
DCO action / DCO (pull_request) Successful in 47s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m4s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m25s
Details
Build / Build Components (pull_request) Successful in 1m53s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m43s
Details
Tests and linters / Lint (pull_request) Successful in 3m13s
Details
Tests and linters / Tests (pull_request) Successful in 3m24s
Details
Tests and linters / gopls check (pull_request) Successful in 3m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m33s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m35s
Details
Vulncheck / Vulncheck (push) Successful in 1m1s
Details
Pre-commit hooks / Pre-commit (push) Successful in 1m27s
Details
Build / Build Components (push) Successful in 1m58s
Details
Tests and linters / Run gofumpt (push) Successful in 2m40s
Details
Tests and linters / Staticcheck (push) Successful in 3m3s
Details
Tests and linters / Lint (push) Successful in 3m7s
Details
Tests and linters / Tests (push) Successful in 3m23s
Details
Tests and linters / gopls check (push) Successful in 3m41s
Details
Tests and linters / Tests with -race (push) Successful in 3m47s
Details
OCI image / Build container images (push) Successful in 4m45s
Details

Browse source 
After adding an ops limiter, shard's `put` pool is redundant.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2025-03-10 13:04:39 +03:00
parent 597bce7a87
commit 2005fdda09
Signed by: dstepanov-yadro
GPG key ID: 237AF1A763293BC0
20 changed files with 71 additions and 171 deletions
Download patch file Download diff file Expand all files Collapse all files

18
pkg/local_object_storage/engine/engine.go
View file

@ -12,7 +12,6 @@ import (
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/mode"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/util/logicerr"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger"
apistatus "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/client/status"
cid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
@ -29,8 +28,6 @@ type StorageEngine struct {
shards map[string]hashedShard
shardPools map[string]util.WorkerPool
closeCh chan struct{}
setModeCh chan setModeRequest
wg sync.WaitGroup
@ -193,8 +190,6 @@ type cfg struct {
metrics MetricRegister
shardPoolSize uint32
lowMem bool
containerSource atomic.Pointer[containerSource]
@ -202,9 +197,8 @@ type cfg struct {
func defaultCfg() *cfg {
res := &cfg{
log: logger.NewLoggerWrapper(zap.L()),
shardPoolSize: 20,
metrics: noopMetrics{},
log: logger.NewLoggerWrapper(zap.L()),
metrics: noopMetrics{},
}
res.containerSource.Store(&containerSource{})
return res
@ -221,7 +215,6 @@ func New(opts ...Option) *StorageEngine {
return &StorageEngine{
cfg: c,
shards: make(map[string]hashedShard),
shardPools: make(map[string]util.WorkerPool),
closeCh: make(chan struct{}),
setModeCh: make(chan setModeRequest),
evacuateLimiter: &evacuationLimiter{},
@ -241,13 +234,6 @@ func WithMetrics(v MetricRegister) Option {
}
}
// WithShardPoolSize returns option to specify size of worker pool for each shard.
func WithShardPoolSize(sz uint32) Option {
return func(c *cfg) {
c.shardPoolSize = sz
}
}
// WithErrorThreshold returns an option to specify size amount of errors after which
// shard is moved to read-only mode.
func WithErrorThreshold(sz uint32) Option {