TrueCloudLab
/
frostfs-node
18
1
Fork 21
Code Issues 89 Pull Requests 7 Actions Releases Activity

[#1236] neofs-node: Remove mutex from `lruNetCache` 

We already use thread-safe LRU and mutex shouldn't be taken while making
network requests.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
remotes/fyrchik/fix-uri-parsing
Evgenii Stratonikov 2022-03-15 11:30:30 +03:00 committed by Alex Vanin
parent 98c84670e3
commit 22b1208a20
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/neofs-node/cache.go
View File

@ -98,14 +98,12 @@ func (c *ttlNetCache) keys() []interface{} {
// entity that provides LRU cache interface. // entity that provides LRU cache interface.
type lruNetCache struct { type lruNetCache struct {
mtx sync.Mutex
cache *lru.Cache cache *lru.Cache
netRdr netValueReader netRdr netValueReader
} }
// complicates netValueReader with LRU caching mechanism. // newNetworkLRUCache returns wrapper over netValueReader with LRU cache.
func newNetworkLRUCache(sz int, netRdr netValueReader) *lruNetCache { func newNetworkLRUCache(sz int, netRdr netValueReader) *lruNetCache {
cache, err := lru.New(sz) cache, err := lru.New(sz)
fatalOnErr(err) fatalOnErr(err)
@ -122,9 +120,6 @@ func newNetworkLRUCache(sz int, netRdr netValueReader) *lruNetCache {
// //
// returned value should not be modified. // returned value should not be modified.
func (c *lruNetCache) get(key interface{}) (interface{}, error) { func (c *lruNetCache) get(key interface{}) (interface{}, error) {
c.mtx.Lock()
defer c.mtx.Unlock()
val, ok := c.cache.Get(key) val, ok := c.cache.Get(key)
if ok { if ok {
return val, nil return val, nil