From 2849e465f9204c4d4e764a8c11ad3b7ecb801d97 Mon Sep 17 00:00:00 2001 From: Pavel Karpy Date: Sun, 4 Sep 2022 11:52:01 +0300 Subject: [PATCH] [#1699] meta: Do not return SplitInfoError on `Delete` It is not an error: removing virtual object is expected and should be just skipped. Getting a virtual object with `raw` flag is considered as an impossible action, all the virtual objects removals will be handled via their children's removals implicitly. Signed-off-by: Pavel Karpy --- CHANGELOG.md | 1 + pkg/local_object_storage/metabase/delete.go | 5 ++++- pkg/local_object_storage/metabase/delete_test.go | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 302e3696..219d7fcb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ Changelog for NeoFS Node - Increase error counter for write-cache flush errors (#1818) - Correctly select the shard for applying tree service operations (#1996) - Do not panic with bad inputs for `GET_RANGE` (#2007) +- Physical child object removal by GC (#1699) ### Removed ### Updated diff --git a/pkg/local_object_storage/metabase/delete.go b/pkg/local_object_storage/metabase/delete.go index 30c80490..e69372b7 100644 --- a/pkg/local_object_storage/metabase/delete.go +++ b/pkg/local_object_storage/metabase/delete.go @@ -157,7 +157,10 @@ func (db *DB) delete(tx *bbolt.Tx, addr oid.Address, refCounter referenceCounter // unmarshal object, work only with physically stored (raw == true) objects obj, err := db.get(tx, addr, key, false, true, currEpoch) if err != nil { - if errors.As(err, new(apistatus.ObjectNotFound)) { + var siErr *objectSDK.SplitInfoError + var notFoundErr apistatus.ObjectNotFound + + if errors.As(err, ¬FoundErr) || errors.As(err, &siErr) { return false, false, nil } diff --git a/pkg/local_object_storage/metabase/delete_test.go b/pkg/local_object_storage/metabase/delete_test.go index dc54b8f4..9202ce63 100644 --- a/pkg/local_object_storage/metabase/delete_test.go +++ b/pkg/local_object_storage/metabase/delete_test.go @@ -39,9 +39,9 @@ func TestDB_Delete(t *testing.T) { require.NoError(t, err) require.Len(t, l, 1) - // try to remove parent unsuccessfully + // try to remove parent, should be no-op, error-free err = metaDelete(db, object.AddressOf(parent)) - require.Error(t, err) + require.NoError(t, err) // inhume parent and child so they will be on graveyard ts := generateObjectWithCID(t, cnr)