TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 95 Pull requests 4 Projects Releases 1 Activity Actions

[#1085] shard: Close components in reverse order

Browse source 
Write-cache should be closed before blobstor and metabase.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
This commit is contained in:
Evgenii Stratonikov 2022-01-18 17:26:30 +03:00 committed by LeL
parent b432ec3a03
commit 3215210d0c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/local_object_storage/shard/control.go
View file

@ -127,14 +127,14 @@ func (s *Shard) refillMetabase() error {
// Close releases all Shard's components. // Close releases all Shard's components.
func (s *Shard) Close() error { func (s *Shard) Close() error {
components := []interface{ Close() error }{ components := []interface{ Close() error }{}
s.blobStor, s.metaBase,
}
if s.hasWriteCache() { if s.hasWriteCache() {
components = append(components, s.writeCache) components = append(components, s.writeCache)
} }
components = append(components, s.blobStor, s.metaBase)
for _, component := range components { for _, component := range components {
if err := component.Close(); err != nil { if err := component.Close(); err != nil {
return fmt.Errorf("could not close %s: %w", component, err) return fmt.Errorf("could not close %s: %w", component, err)