TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 93 Pull requests 4 Projects Releases 1 Activity Actions

[#1238] Call String() explicitly instead of using stringer pointer

Browse source 
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
This commit is contained in:
Alex Vanin 2022-03-16 15:18:56 +03:00 committed by Alex Vanin
parent 8f476f3c4d
commit 362cda53d2
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/neofs-cli/modules/container.go
View file

@ -602,7 +602,7 @@ func getSessionToken(path string) (*session.Token, error) {
func prettyPrintContainerList(cmd *cobra.Command, list []cid.ID) {
for i := range list {
cmd.Println(&list[i]) // stringer defined on pointer
cmd.Println(list[i].String())
}
}

2
cmd/neofs-cli/modules/object.go
View file

@ -894,7 +894,7 @@ func printSplitHeader(cmd *cobra.Command, obj *object.Object) error {
}
for _, child := range obj.Children() {
cmd.Printf("Split ChildID: %s\n", &child) // stringer defined on pointer
cmd.Printf("Split ChildID: %s\n", child.String())
}
if signature := obj.Signature(); signature != nil {

2
cmd/neofs-cli/modules/storagegroup.go
View file

@ -261,7 +261,7 @@ func getSG(cmd *cobra.Command, _ []string) {
cmd.Println("Members:")
for i := range members {
cmd.Printf("\t%s\n", &members[i]) // stringer defined on pointer
cmd.Printf("\t%s\n", members[i].String())
}
}
}

2
pkg/innerring/processors/settlement/audit/calculate.go
View file

@ -223,7 +223,7 @@ func (c *Calculator) sumSGSizes(ctx *singleResultCtx) bool {
sgInfo, err := c.prm.SGStorage.SGInfo(addr)
if err != nil {
ctx.log.Error("could not get SG info",
zap.Stringer("id", &passSG[i]), // stringer defined on pointer
zap.String("id", passSG[i].String()),
)
return false // we also can continue and calculate at least some part

6
pkg/services/audit/auditor/por.go
View file

@ -60,7 +60,7 @@ func (c *Context) checkStorageGroupPoR(ind int, sg *oidSDK.ID) {
if err != nil {
c.log.Info("can't build placement for storage group member",
zap.Stringer("sg", sg),
zap.Stringer("member_id", &members[i]), // stringer defined on pointer
zap.String("member_id", members[i].String()),
)
continue
@ -82,7 +82,7 @@ func (c *Context) checkStorageGroupPoR(ind int, sg *oidSDK.ID) {
if err != nil {
c.log.Debug("can't head object",
zap.String("remote_node", hex.EncodeToString(flat[j].PublicKey())),
zap.Stringer("oid", &members[i])) // stringer defined on pointer
zap.String("oid", members[i].String()))
continue
}
@ -99,7 +99,7 @@ func (c *Context) checkStorageGroupPoR(ind int, sg *oidSDK.ID) {
})
if err != nil {
c.log.Debug("can't concatenate tz hash",
zap.Stringer("oid", &members[i]), // stringer defined on pointer
zap.String("oid", members[i].String()),
zap.String("error", err.Error()))
break