innerring: Relax container homomorphic hashing check
Some checks failed
DCO action / DCO (pull_request) Failing after 36s
Vulncheck / Vulncheck (pull_request) Successful in 1m9s
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m22s
Build / Build Components (pull_request) Successful in 1m35s
Tests and linters / Run gofumpt (pull_request) Successful in 2m54s
Tests and linters / Staticcheck (pull_request) Successful in 3m24s
Tests and linters / Lint (pull_request) Successful in 3m29s
Tests and linters / Tests (pull_request) Successful in 3m19s
Tests and linters / gopls check (pull_request) Successful in 4m21s
Tests and linters / Tests with -race (pull_request) Successful in 4m24s
Some checks failed
DCO action / DCO (pull_request) Failing after 36s
Vulncheck / Vulncheck (pull_request) Successful in 1m9s
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m22s
Build / Build Components (pull_request) Successful in 1m35s
Tests and linters / Run gofumpt (pull_request) Successful in 2m54s
Tests and linters / Staticcheck (pull_request) Successful in 3m24s
Tests and linters / Lint (pull_request) Successful in 3m29s
Tests and linters / Tests (pull_request) Successful in 3m19s
Tests and linters / gopls check (pull_request) Successful in 4m21s
Tests and linters / Tests with -race (pull_request) Successful in 4m24s
Our initial desire was to prohibit using homomorphic hashing on the network level because of the resource consumption. However, the ability to use it, doesn't mean that we must. So only fail validation if container wants to have homomorphic hashing, but the network prohibits it. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
This commit is contained in:
parent
b2adf1109e
commit
38216ba8ba
1 changed files with 1 additions and 1 deletions
|
@ -209,7 +209,7 @@ func checkHomomorphicHashing(ctx context.Context, ns NetworkState, cnr container
|
|||
return fmt.Errorf("could not get setting in contract: %w", err)
|
||||
}
|
||||
|
||||
if cnrSetting := containerSDK.IsHomomorphicHashingDisabled(cnr); netSetting != cnrSetting {
|
||||
if cnrSetting := containerSDK.IsHomomorphicHashingDisabled(cnr); netSetting && !cnrSetting {
|
||||
return fmt.Errorf("network setting: %t, container setting: %t", netSetting, cnrSetting)
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue