From 44b86bac5aa9121fbb19298ae13dcc8a9673bb7a Mon Sep 17 00:00:00 2001
From: Dmitrii Stepanov <d.stepanov@yadro.com>
Date: Mon, 20 Mar 2023 15:10:53 +0300
Subject: [PATCH] [#148] linter: Add contextcheck linter

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
---
 .golangci.yml                        | 1 +
 pkg/services/control/server/gc.go    | 1 +
 pkg/services/object/get/assemble.go  | 3 ++-
 pkg/services/object/get/get.go       | 1 +
 pkg/services/object/get/remote.go    | 1 +
 pkg/services/object/search/search.go | 1 +
 pkg/services/policer/check.go        | 2 ++
 pkg/services/tree/replicator.go      | 1 +
 8 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/.golangci.yml b/.golangci.yml
index 4612d96a..ac77301b 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -61,5 +61,6 @@ linters:
     - containedctx
     - funlen
     - gocognit
+    - contextcheck
   disable-all: true
   fast: false
diff --git a/pkg/services/control/server/gc.go b/pkg/services/control/server/gc.go
index ea1f626f..7fa0a060 100644
--- a/pkg/services/control/server/gc.go
+++ b/pkg/services/control/server/gc.go
@@ -41,6 +41,7 @@ func (s *Server) DropObjects(_ context.Context, req *control.DropObjectsRequest)
 		prm.WithForceRemoval()
 		prm.WithAddress(addrList[i])
 
+		//nolint: contextcheck
 		_, err := s.s.Delete(prm)
 		if err != nil && firstErr == nil {
 			firstErr = err
diff --git a/pkg/services/object/get/assemble.go b/pkg/services/object/get/assemble.go
index ed77b569..ebae18eb 100644
--- a/pkg/services/object/get/assemble.go
+++ b/pkg/services/object/get/assemble.go
@@ -107,7 +107,7 @@ func (exec *execCtx) HeadObject(ctx context.Context, id oid.ID) (*objectSDK.Obje
 
 	w := NewSimpleObjectWriter()
 	prm.SetHeaderWriter(w)
-
+	//nolint: contextcheck
 	err := exec.svc.Head(exec.context(), prm)
 
 	if err != nil {
@@ -128,6 +128,7 @@ func (exec *execCtx) GetObject(ctx context.Context, id oid.ID, rng *objectSDK.Ra
 	p.addr.SetContainer(exec.containerID())
 	p.addr.SetObject(id)
 
+	//nolint: contextcheck
 	statusError := exec.svc.get(exec.context(), p.commonPrm, withPayloadRange(rng))
 
 	if statusError.err != nil {
diff --git a/pkg/services/object/get/get.go b/pkg/services/object/get/get.go
index f3d5f8a5..cdb2d96f 100644
--- a/pkg/services/object/get/get.go
+++ b/pkg/services/object/get/get.go
@@ -78,6 +78,7 @@ func (s *Service) get(ctx context.Context, prm commonPrm, opts ...execOption) st
 
 	exec.setLogger(s.log)
 
+	//nolint: contextcheck
 	exec.execute()
 
 	return exec.statusError
diff --git a/pkg/services/object/get/remote.go b/pkg/services/object/get/remote.go
index da310d24..fbfb01bc 100644
--- a/pkg/services/object/get/remote.go
+++ b/pkg/services/object/get/remote.go
@@ -43,6 +43,7 @@ func (exec *execCtx) processNode(ctx context.Context, info client.NodeInfo) bool
 		// has already been streamed to the requesting party
 		if obj != nil {
 			exec.collectedObject = obj
+			//nolint: contextcheck
 			exec.writeCollectedObject()
 		}
 	case errors.As(err, &errRemoved):
diff --git a/pkg/services/object/search/search.go b/pkg/services/object/search/search.go
index 5e1249a1..5a688092 100644
--- a/pkg/services/object/search/search.go
+++ b/pkg/services/object/search/search.go
@@ -18,6 +18,7 @@ func (s *Service) Search(ctx context.Context, prm Prm) error {
 
 	exec.setLogger(s.log)
 
+	//nolint: contextcheck
 	exec.execute()
 
 	return exec.statusError.err
diff --git a/pkg/services/policer/check.go b/pkg/services/policer/check.go
index 7b4bf826..7d4b714f 100644
--- a/pkg/services/policer/check.go
+++ b/pkg/services/policer/check.go
@@ -81,6 +81,7 @@ func (p *Policer) processObject(ctx context.Context, addrWithType objectcore.Add
 			prm.MarkAsGarbage(addrWithType.Address)
 			prm.WithForceRemoval()
 
+			//nolint: contextcheck
 			_, err := p.jobQueue.localStorage.Inhume(prm)
 			if err != nil {
 				p.log.Error("could not inhume object with missing container",
@@ -124,6 +125,7 @@ func (p *Policer) processObject(ctx context.Context, addrWithType objectcore.Add
 		default:
 		}
 
+		//nolint: contextcheck
 		p.processNodes(c, addrWithType, nn[i], policy.ReplicaNumberByIndex(i), checkedNodes)
 	}
 
diff --git a/pkg/services/tree/replicator.go b/pkg/services/tree/replicator.go
index 0c3c35f7..01bd2deb 100644
--- a/pkg/services/tree/replicator.go
+++ b/pkg/services/tree/replicator.go
@@ -94,6 +94,7 @@ func (s *Service) replicationWorker() {
 
 func (s *Service) replicateLoop(ctx context.Context) {
 	for i := 0; i < s.replicatorWorkerCount; i++ {
+		//nolint: contextcheck
 		go s.replicationWorker()
 		go s.localReplicationWorker()
 	}