TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 7 Projects Releases 1 Activity Actions

[#943] service/object: Do not sign put service message with session token

Browse source 
This is invalid operation for storage nodes that receive part of split
object. While object is signed by session token, the message itself
should be signed by the node key.

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
This commit is contained in:
Alex Vanin 2021-10-25 15:13:36 +03:00 committed by Alex Vanin
parent 46fa07b7cc
commit 508a28fdc0
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/services/object/put/v2/streamer.go
View file

@ -4,7 +4,6 @@ import (
"errors" "errors"
"fmt" "fmt"
"github.com/nspcc-dev/neofs-api-go/pkg/session"
"github.com/nspcc-dev/neofs-api-go/v2/object" "github.com/nspcc-dev/neofs-api-go/v2/object"
"github.com/nspcc-dev/neofs-api-go/v2/rpc" "github.com/nspcc-dev/neofs-api-go/v2/rpc"
sessionV2 "github.com/nspcc-dev/neofs-api-go/v2/session" sessionV2 "github.com/nspcc-dev/neofs-api-go/v2/session"
@ -97,13 +96,15 @@ func (s *streamer) Send(req *object.PutRequest) (err error) {
metaHdr := new(sessionV2.RequestMetaHeader) metaHdr := new(sessionV2.RequestMetaHeader)
meta := req.GetMetaHeader() meta := req.GetMetaHeader()
st := session.NewTokenFromV2(meta.GetSessionToken())
metaHdr.SetTTL(meta.GetTTL() - 1) metaHdr.SetTTL(meta.GetTTL() - 1)
metaHdr.SetOrigin(meta) metaHdr.SetOrigin(meta)
req.SetMetaHeader(metaHdr) req.SetMetaHeader(metaHdr)
key, err := s.keyStorage.GetKey(st) // session token should not be used there
// otherwise remote nodes won't be able to
// process received part of split object
key, err := s.keyStorage.GetKey(nil)
if err != nil { if err != nil {
return err return err
} }