TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

[#1441] cli: Use grpc.WaitForReady while initializing SDK client
All checks were successful
DCO action / DCO (pull_request) Successful in 54s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m58s
Details
Build / Build Components (pull_request) Successful in 2m21s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m9s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m21s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m57s
Details
Tests and linters / Lint (pull_request) Successful in 3m32s
Details
Tests and linters / Tests (pull_request) Successful in 3m41s
Details
Tests and linters / gopls check (pull_request) Successful in 3m40s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m7s
Details

Browse source 
Before, when the target RPC server was unavailable, requests made
by CLI didn't wait for a timeout specified by the `--timeout` option
if the timeout was more than 20 seconds. It's because of the gRPC
default backoff strategy. Adding this option fixes that behavior.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
This commit is contained in:
Aleksey Savchuk 2024-10-22 10:18:01 +03:00
parent 8b6ec57c61
commit 602c42a237
Signed by: a-savchuk
GPG key ID: 70C0A7FF6F9C4639
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cmd/frostfs-cli/internal/client/sdk.go
View file

@ -58,6 +58,7 @@ func GetSDKClient(ctx context.Context, cmd *cobra.Command, key *ecdsa.PrivateKey
GRPCDialOptions: []grpc.DialOption{ GRPCDialOptions: []grpc.DialOption{
grpc.WithChainUnaryInterceptor(tracing.NewUnaryClientInteceptor()), grpc.WithChainUnaryInterceptor(tracing.NewUnaryClientInteceptor()),
grpc.WithChainStreamInterceptor(tracing.NewStreamClientInterceptor()), grpc.WithChainStreamInterceptor(tracing.NewStreamClientInterceptor()),
grpc.WithDefaultCallOptions(grpc.WaitForReady(true)),
}, },
} }
if timeout := viper.GetDuration(commonflags.Timeout); timeout > 0 { if timeout := viper.GetDuration(commonflags.Timeout); timeout > 0 {

1
cmd/frostfs-cli/modules/tree/client.go
View file

@ -34,6 +34,7 @@ func _client() (tree.TreeServiceClient, error) {
metrics.NewStreamClientInterceptor(), metrics.NewStreamClientInterceptor(),
tracing.NewStreamClientInterceptor(), tracing.NewStreamClientInterceptor(),
), ),
grpc.WithDefaultCallOptions(grpc.WaitForReady(true)),
} }
if !strings.HasPrefix(netAddr.URIAddr(), "grpcs:") { if !strings.HasPrefix(netAddr.URIAddr(), "grpcs:") {