TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 8 Projects Releases 1 Activity Actions

[#613] pkg/innerring/reputation: Add FIXME to ToV2 usage

Browse source 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This commit is contained in:
Pavel Karpy 2021-06-17 18:08:08 +03:00 committed by Pavel Karpy
parent ed9a5e44b6
commit 68c7f6ce8a
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/innerring/processors/reputation/handlers.go
View file

@ -12,6 +12,7 @@ func (rp *Processor) handlePutReputation(ev event.Event) {
put := ev.(reputationEvent.Put) put := ev.(reputationEvent.Put)
peerID := put.PeerID() peerID := put.PeerID()
// FIXME: do not use `ToV2` method outside neofs-api-go library
rp.log.Info("notification", rp.log.Info("notification",
zap.String("type", "reputation put"), zap.String("type", "reputation put"),
zap.String("peer_id", hex.EncodeToString(peerID.ToV2().GetPublicKey()))) zap.String("peer_id", hex.EncodeToString(peerID.ToV2().GetPublicKey())))

2
pkg/innerring/processors/reputation/process_put.go
View file

@ -56,6 +56,7 @@ func (rp *Processor) processPut(epoch uint64, id apireputation.PeerID, value api
err := rp.reputationWrp.Put(args) err := rp.reputationWrp.Put(args)
if err != nil { if err != nil {
// FIXME: do not use `ToV2` method outside neofs-api-go library
rp.log.Warn("can't send approval tx for reputation value", rp.log.Warn("can't send approval tx for reputation value",
zap.String("peer_id", hex.EncodeToString(id.ToV2().GetPublicKey())), zap.String("peer_id", hex.EncodeToString(id.ToV2().GetPublicKey())),
zap.String("error", err.Error())) zap.String("error", err.Error()))
@ -69,6 +70,7 @@ func (rp *Processor) checkManagers(e uint64, mng apireputation.PeerID, peer apir
} }
for _, m := range mm { for _, m := range mm {
// FIXME: do not use `ToV2` method outside neofs-api-go library
if bytes.Equal(mng.ToV2().GetPublicKey(), m.PublicKey()) { if bytes.Equal(mng.ToV2().GetPublicKey(), m.PublicKey()) {
return nil return nil
} }