TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 6 Projects Releases 1 Activity Actions

[#1448] container/ape: Ignore an error when getting a role
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 1m26s
Details
DCO action / DCO (pull_request) Successful in 1m39s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m9s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m22s
Details
Build / Build Components (pull_request) Successful in 2m28s
Details
Tests and linters / gopls check (pull_request) Successful in 2m54s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m56s
Details
Tests and linters / Lint (pull_request) Successful in 4m12s
Details
Tests and linters / Tests (pull_request) Successful in 4m44s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m5s
Details

Browse source 
When getting a role in the APE checker for the container services,
an error may be returned if network maps of the previous two epochs
don't have enough nodes to fulfil a container placement policy.
It's a logical error, so we should ignore it.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
This commit is contained in:
Aleksey Savchuk 2024-10-29 15:47:19 +03:00
parent e70c2cedbe
commit 6daa1fda7f
Signed by: a-savchuk
GPG key ID: 70C0A7FF6F9C4639
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/services/container/ape.go
View file

@ -550,10 +550,9 @@ func (ac *apeChecker) isContainerKey(pk []byte, cnrID cid.ID, cont *containercor
} }
func isContainerNode(nm *netmapSDK.NetMap, pk, binCnrID []byte, cont *containercore.Container) bool { func isContainerNode(nm *netmapSDK.NetMap, pk, binCnrID []byte, cont *containercore.Container) bool {
// An error may be returned if network maps of the previous two epochs // It could an error only if the network map doesn't have enough nodes to
// don't have enough nodes to fulfil a container placement policy. // fulfil the policy. It's a logical error that doesn't affect an actor role
// It's a logical error, so we should ignore it. // determining, so we ignore it
// See https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/1448.
cnrVectors, _ := nm.ContainerNodes(cont.Value.PlacementPolicy(), binCnrID) cnrVectors, _ := nm.ContainerNodes(cont.Value.PlacementPolicy(), binCnrID)
for i := range cnrVectors { for i := range cnrVectors {