TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 107 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#1484] engine: Fix engine metrics
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 2m38s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m51s
Details
DCO action / DCO (pull_request) Successful in 2m53s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m44s
Details
Tests and linters / gopls check (pull_request) Successful in 3m53s
Details
Build / Build Components (pull_request) Successful in 4m15s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m56s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m5s
Details
Tests and linters / Lint (pull_request) Successful in 5m47s
Details
Tests and linters / Tests (pull_request) Successful in 5m51s
Details

Browse source 
1. Add forgotten metrics for client requests
2. Include execIfNotBlocked into metrics

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2024-11-11 12:46:55 +03:00
parent ad01fb958a
commit 8a57c78f5f
Signed by: dstepanov-yadro
GPG key ID: 237AF1A763293BC0
9 changed files with 25 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

3
pkg/local_object_storage/engine/put.go
View file

@ -56,6 +56,7 @@ func (e *StorageEngine) Put(ctx context.Context, prm PutPrm) (err error) {
attribute.String("address", object.AddressOf(prm.Object).EncodeToString()),
))
defer span.End()
defer elapsed("Put", e.metrics.AddMethodDuration)()
err = e.execIfNotBlocked(func() error {
err = e.put(ctx, prm)
@ -66,8 +67,6 @@ func (e *StorageEngine) Put(ctx context.Context, prm PutPrm) (err error) {
}
func (e *StorageEngine) put(ctx context.Context, prm PutPrm) error {
defer elapsed("Put", e.metrics.AddMethodDuration)()
addr := object.AddressOf(prm.Object)
// In #1146 this check was parallelized, however, it became