TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 107 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#1124] cli: Improve APE rule parsing
All checks were successful
Vulncheck / Vulncheck (pull_request) Successful in 1m25s
Details
DCO action / DCO (pull_request) Successful in 1m59s
Details
Build / Build Components (1.21) (pull_request) Successful in 2m27s
Details
Build / Build Components (1.22) (pull_request) Successful in 4m25s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m57s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m38s
Details
Tests and linters / gopls check (pull_request) Successful in 5m57s
Details
Tests and linters / Lint (pull_request) Successful in 6m26s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 9m5s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 9m11s
Details
Tests and linters / Tests with -race (pull_request) Successful in 9m4s
Details

Browse source 
* Make APE rule parser to read condition's kind in unambiguous using lexemes
`ResourceCondition`, `RequestCondition` instead confusing `Object.Request`, `Object.Resource`.
* Fix unit-tests.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
This commit is contained in:
Airat Arifullin 2024-05-14 12:23:26 +03:00
parent 20baf6e112
commit 952d13cd2b
8 changed files with 151 additions and 147 deletions
Download patch file Download diff file Expand all files Collapse all files

32
pkg/services/object/ape/checker_test.go
View file

@ -312,10 +312,10 @@ func TestAPECheck(t *testing.T) {
Any: true,
Condition: []chain.Condition{
{
Op: chain.CondStringLike,
Object: chain.ObjectResource,
Key: "attr1",
Value: "attribute*",
Op: chain.CondStringLike,
Kind: chain.KindResource,
Key: "attr1",
Value: "attribute*",
},
},
},
@ -351,10 +351,10 @@ func TestAPECheck(t *testing.T) {
Any: true,
Condition: []chain.Condition{
{
Op: chain.CondStringLike,
Object: chain.ObjectRequest,
Key: nativeschema.PropertyKeyActorPublicKey,
Value: senderKey,
Op: chain.CondStringLike,
Kind: chain.KindRequest,
Key: nativeschema.PropertyKeyActorPublicKey,
Value: senderKey,
},
},
},
@ -381,10 +381,10 @@ func TestAPECheck(t *testing.T) {
Any: true,
Condition: []chain.Condition{
{
Op: chain.CondStringEquals,
Object: chain.ObjectResource,
Key: nativeschema.PropertyKeyObjectPayloadLength,
Value: "1000",
Op: chain.CondStringEquals,
Kind: chain.KindResource,
Key: nativeschema.PropertyKeyObjectPayloadLength,
Value: "1000",
},
},
},
@ -503,10 +503,10 @@ func TestPutECChunk(t *testing.T) {
Any: true,
Condition: []chain.Condition{
{
Op: chain.CondStringEquals,
Object: chain.ObjectResource,
Key: "attr1",
Value: "value",
Op: chain.CondStringEquals,
Kind: chain.KindResource,
Key: "attr1",
Value: "value",
},
},
},