TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

[#859] config: rename max_size to max_object_size

Browse source 
`_size` suffix by itself makes me think about restrictions on database
size.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
This commit is contained in:
Evgenii Stratonikov 2021-10-18 17:12:03 +03:00 committed by Alex Vanin
parent da51c119d5
commit a180f09523
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cmd/neofs-node/config/engine/shard/writecache/config.go
View file

@ -79,13 +79,13 @@ func (x *Config) SmallObjectSize() uint64 {
return SmallSizeDefault return SmallSizeDefault
} }
// MaxObjectSize returns value of "max_size" config parameter. // MaxObjectSize returns value of "max_object_size" config parameter.
// //
// Returns MaxSizeDefault if value is not a positive number. // Returns MaxSizeDefault if value is not a positive number.
func (x *Config) MaxObjectSize() uint64 { func (x *Config) MaxObjectSize() uint64 {
s := config.SizeInBytesSafe( s := config.SizeInBytesSafe(
(*config.Config)(x), (*config.Config)(x),
"max_size", "max_object_size",
) )
if s > 0 { if s > 0 {

4
config/example/node.env
View file

@ -75,7 +75,7 @@ NEOFS_STORAGE_SHARD_0_USE_WRITE_CACHE=false
NEOFS_STORAGE_SHARD_0_WRITECACHE_PATH=tmp/0/cache NEOFS_STORAGE_SHARD_0_WRITECACHE_PATH=tmp/0/cache
NEOFS_STORAGE_SHARD_0_WRITECACHE_MEM_SIZE=2147483648 NEOFS_STORAGE_SHARD_0_WRITECACHE_MEM_SIZE=2147483648
NEOFS_STORAGE_SHARD_0_WRITECACHE_SMALL_OBJECT_SIZE=16384 NEOFS_STORAGE_SHARD_0_WRITECACHE_SMALL_OBJECT_SIZE=16384
NEOFS_STORAGE_SHARD_0_WRITECACHE_MAX_SIZE=134217728 NEOFS_STORAGE_SHARD_0_WRITECACHE_MAX_OBJECT_SIZE=134217728
NEOFS_STORAGE_SHARD_0_WRITECACHE_WORKERS_NUMBER=30 NEOFS_STORAGE_SHARD_0_WRITECACHE_WORKERS_NUMBER=30
NEOFS_STORAGE_SHARD_0_WRITECACHE_SIZE_LIMIT=3221225472 NEOFS_STORAGE_SHARD_0_WRITECACHE_SIZE_LIMIT=3221225472
### Metabase config ### Metabase config
@ -106,7 +106,7 @@ NEOFS_STORAGE_SHARD_1_USE_WRITE_CACHE=true
NEOFS_STORAGE_SHARD_1_WRITECACHE_PATH=tmp/1/cache NEOFS_STORAGE_SHARD_1_WRITECACHE_PATH=tmp/1/cache
NEOFS_STORAGE_SHARD_1_WRITECACHE_MEM_SIZE=2147483648 NEOFS_STORAGE_SHARD_1_WRITECACHE_MEM_SIZE=2147483648
NEOFS_STORAGE_SHARD_1_WRITECACHE_SMALL_OBJECT_SIZE=16384 NEOFS_STORAGE_SHARD_1_WRITECACHE_SMALL_OBJECT_SIZE=16384
NEOFS_STORAGE_SHARD_1_WRITECACHE_MAX_SIZE=134217728 NEOFS_STORAGE_SHARD_1_WRITECACHE_MAX_OBJECT_SIZE=134217728
NEOFS_STORAGE_SHARD_1_WRITECACHE_WORKERS_NUMBER=30 NEOFS_STORAGE_SHARD_1_WRITECACHE_WORKERS_NUMBER=30
NEOFS_STORAGE_SHARD_1_WRITECACHE_SIZE_LIMIT=4294967296 NEOFS_STORAGE_SHARD_1_WRITECACHE_SIZE_LIMIT=4294967296
### Metabase config ### Metabase config

4
config/example/node.json
View file

@ -107,7 +107,7 @@
"path": "tmp/0/cache", "path": "tmp/0/cache",
"mem_size": 2147483648, "mem_size": 2147483648,
"small_object_size": 16384, "small_object_size": 16384,
"max_size": 134217728, "max_object_size": 134217728,
"workers_number": 30, "workers_number": 30,
"size_limit": 3221225472 "size_limit": 3221225472
}, },
@ -140,7 +140,7 @@
"path": "tmp/1/cache", "path": "tmp/1/cache",
"mem_size": 2147483648, "mem_size": 2147483648,
"small_object_size": 16384, "small_object_size": 16384,
"max_size": 134217728, "max_object_size": 134217728,
"workers_number": 30, "workers_number": 30,
"size_limit": 4294967296 "size_limit": 4294967296
}, },

2
config/example/node.yaml
View file

@ -95,7 +95,7 @@ storage:
writecache: writecache:
mem_size: 2147483648 # approximate RAM usage limit for "small" objects, bytes mem_size: 2147483648 # approximate RAM usage limit for "small" objects, bytes
small_object_size: 16384 # size threshold for "small" objects which are cached in key-value DB, not in FS, bytes small_object_size: 16384 # size threshold for "small" objects which are cached in key-value DB, not in FS, bytes
max_size: 134217728 # size threshold for "big" objects which bypass write-cache and go to the storage directly, bytes max_object_size: 134217728 # size threshold for "big" objects which bypass write-cache and go to the storage directly, bytes
workers_number: 30 # number of write-cache flusher threads workers_number: 30 # number of write-cache flusher threads
metabase: metabase: