[#576] Set SyncWrites for badger writecache by default

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>

pkg/local_object_storage/writecache/writecachebadger/options.go

@@ -47,8 +47,6 @@ type options struct {
 	maxCacheSize uint64
 	// objCounters contains atomic counters for the number of objects stored in cache.
 	objCounters counters
-	// noSync is true iff FSTree allows unsynchronized writes.
-	noSync bool
 	// reportError is the function called when encountering disk errors in background workers.
 	reportError func(string, error)
 	// metrics is metrics implementation
@@ -109,16 +107,6 @@ func WithMaxCacheSize(sz uint64) Option {
 	}
 }
 
-// WithNoSync sets an option to allow returning to caller on PUT before write is persisted.
-// Note, that we use this flag for FSTree only and DO NOT use it for a bolt DB because
-// we cannot yet properly handle the corrupted database during the startup. This SHOULD NOT
-// be relied upon and may be changed in future.
-func WithNoSync(noSync bool) Option {
-	return func(o *options) {
-		o.noSync = noSync
-	}
-}
-
 // WithReportErrorFunc sets error reporting function.
 func WithReportErrorFunc(f func(string, error)) Option {
 	return func(o *options) {