TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 92 Pull requests 4 Projects Releases 1 Activity Actions

[#1071] Revert "[#446] engine: Move to read-only on blobstor errors"
Some checks failed
DCO action / DCO (pull_request) Successful in 3m47s
Details
Vulncheck / Vulncheck (pull_request) Failing after 3m56s
Details
Build / Build Components (1.21) (pull_request) Successful in 5m10s
Details
Build / Build Components (1.20) (pull_request) Successful in 6m4s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m42s
Details
Tests and linters / Tests with -race (pull_request) Failing after 12m32s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 13m37s
Details
Tests and linters / Lint (pull_request) Successful in 11m34s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 3m2s
Details

Browse source 
This reverts commit 69df0d21c2.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
This commit is contained in:
Evgenii Stratonikov 2024-03-28 11:08:20 +03:00
parent 2bfaa65455
commit bb6d8d0c0d
2 changed files with 15 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
pkg/local_object_storage/engine/engine.go
View file

@ -7,7 +7,6 @@ import (
"sync/atomic" "sync/atomic"
"git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs" "git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/internal/metaerr"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard" "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/mode" "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard/mode"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/util/logicerr" "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/util/logicerr"
@ -48,7 +47,6 @@ type shardWrapper struct {
type setModeRequest struct { type setModeRequest struct {
sh *shard.Shard sh *shard.Shard
isMeta bool
errorCount uint32 errorCount uint32
} }
@ -74,7 +72,7 @@ func (e *StorageEngine) setModeLoop() {
if !ok { if !ok {
inProgress[sid] = struct{}{} inProgress[sid] = struct{}{}
go func() { go func() {
e.moveToDegraded(r.sh, r.errorCount, r.isMeta) e.moveToDegraded(r.sh, r.errorCount)
mtx.Lock() mtx.Lock()
delete(inProgress, sid) delete(inProgress, sid)
@ -86,7 +84,7 @@ func (e *StorageEngine) setModeLoop() {
} }
} }
func (e *StorageEngine) moveToDegraded(sh *shard.Shard, errCount uint32, isMeta bool) { func (e *StorageEngine) moveToDegraded(sh *shard.Shard, errCount uint32) {
sid := sh.ID() sid := sh.ID()
log := e.log.With( log := e.log.With(
zap.Stringer("shard_id", sid), zap.Stringer("shard_id", sid),
@ -95,23 +93,21 @@ func (e *StorageEngine) moveToDegraded(sh *shard.Shard, errCount uint32, isMeta
e.mtx.RLock() e.mtx.RLock()
defer e.mtx.RUnlock() defer e.mtx.RUnlock()
if isMeta { err := sh.SetMode(mode.DegradedReadOnly)
err := sh.SetMode(mode.DegradedReadOnly) if err != nil {
if err == nil {
log.Info(logs.EngineShardIsMovedInDegradedModeDueToErrorThreshold)
return
}
log.Error(logs.EngineFailedToMoveShardInDegradedreadonlyModeMovingToReadonly, log.Error(logs.EngineFailedToMoveShardInDegradedreadonlyModeMovingToReadonly,
zap.Error(err)) zap.Error(err))
}
err := sh.SetMode(mode.ReadOnly) err = sh.SetMode(mode.ReadOnly)
if err != nil { if err != nil {
log.Error(logs.EngineFailedToMoveShardInReadonlyMode, zap.Error(err)) log.Error(logs.EngineFailedToMoveShardInReadonlyMode,
return zap.Error(err))
} else {
log.Info(logs.EngineShardIsMovedInReadonlyModeDueToErrorThreshold)
}
} else {
log.Info(logs.EngineShardIsMovedInDegradedModeDueToErrorThreshold)
} }
log.Info(logs.EngineShardIsMovedInReadonlyModeDueToErrorThreshold)
} }
// reportShardErrorBackground increases shard error counter and logs an error. // reportShardErrorBackground increases shard error counter and logs an error.
@ -175,13 +171,11 @@ func (e *StorageEngine) reportShardErrorWithFlags(
return return
} }
isMeta := errors.As(err, new(metaerr.Error))
if block { if block {
e.moveToDegraded(sh, errCount, isMeta) e.moveToDegraded(sh, errCount)
} else { } else {
req := setModeRequest{ req := setModeRequest{
errorCount: errCount, errorCount: errCount,
isMeta: isMeta,
sh: sh, sh: sh,
} }

2
pkg/local_object_storage/engine/error_test.go
View file

@ -152,7 +152,7 @@ func TestErrorReporting(t *testing.T) {
for i := uint32(0); i < 2; i++ { for i := uint32(0); i < 2; i++ {
_, err = te.ng.Get(context.Background(), GetPrm{addr: object.AddressOf(obj)}) _, err = te.ng.Get(context.Background(), GetPrm{addr: object.AddressOf(obj)})
require.Error(t, err) require.Error(t, err)
checkShardState(t, te.ng, te.shards[0].id, errThreshold+i, mode.ReadOnly) checkShardState(t, te.ng, te.shards[0].id, errThreshold+i, mode.DegradedReadOnly)
checkShardState(t, te.ng, te.shards[1].id, 0, mode.ReadWrite) checkShardState(t, te.ng, te.shards[1].id, 0, mode.ReadWrite)
} }