From bc045b29e21b458c9d3f244f05a16bce9869059e Mon Sep 17 00:00:00 2001
From: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
Date: Tue, 8 Apr 2025 16:54:05 +0300
Subject: [PATCH] [#1693] services: Replace conditional panics with asserts

Change-Id: Ic79609e6ad867caa88ad245b3014aa7fc32e05a8
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
---
 pkg/services/netmap/executor.go                       | 11 +++++++----
 pkg/services/object_manager/tombstone/constructor.go  |  5 ++---
 .../object_manager/tombstone/source/source.go         |  5 ++---
 pkg/services/policer/policer.go                       |  6 +++---
 4 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/pkg/services/netmap/executor.go b/pkg/services/netmap/executor.go
index 44101a153..1b92fdaad 100644
--- a/pkg/services/netmap/executor.go
+++ b/pkg/services/netmap/executor.go
@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 
+	"git.frostfs.info/TrueCloudLab/frostfs-node/internal/assert"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/core/version"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/util/response"
 	"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/api/netmap"
@@ -46,10 +47,12 @@ type NetworkInfo interface {
 }
 
 func NewExecutionService(s NodeState, v versionsdk.Version, netInfo NetworkInfo, respSvc *response.Service) Server {
-	if s == nil || netInfo == nil || !version.IsValid(v) || respSvc == nil {
-		// this should never happen, otherwise it programmers bug
-		panic("can't create netmap execution service")
-	}
+	// this should never happen, otherwise it's a programmer's bug
+	msg := "BUG: can't create netmap execution service"
+	assert.False(s == nil, msg, "node state is nil")
+	assert.False(netInfo == nil, msg, "network info is nil")
+	assert.False(respSvc == nil, msg, "response service is nil")
+	assert.True(version.IsValid(v), msg, "invalid version")
 
 	res := &executorSvc{
 		state:   s,
diff --git a/pkg/services/object_manager/tombstone/constructor.go b/pkg/services/object_manager/tombstone/constructor.go
index 67ddf316f..2147a32fe 100644
--- a/pkg/services/object_manager/tombstone/constructor.go
+++ b/pkg/services/object_manager/tombstone/constructor.go
@@ -3,6 +3,7 @@ package tombstone
 import (
 	"fmt"
 
+	"git.frostfs.info/TrueCloudLab/frostfs-node/internal/assert"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger"
 	lru "github.com/hashicorp/golang-lru/v2"
 	"go.uber.org/zap"
@@ -49,9 +50,7 @@ func NewChecker(oo ...Option) *ExpirationChecker {
 	panicOnNil(cfg.tsSource, "Tombstone source")
 
 	cache, err := lru.New[string, uint64](cfg.cacheSize)
-	if err != nil {
-		panic(fmt.Errorf("could not create LRU cache with %d size: %w", cfg.cacheSize, err))
-	}
+	assert.NoError(err, fmt.Sprintf("could not create LRU cache with %d size", cfg.cacheSize))
 
 	return &ExpirationChecker{
 		cache:    cache,
diff --git a/pkg/services/object_manager/tombstone/source/source.go b/pkg/services/object_manager/tombstone/source/source.go
index 1ff07b05a..975941847 100644
--- a/pkg/services/object_manager/tombstone/source/source.go
+++ b/pkg/services/object_manager/tombstone/source/source.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 
+	"git.frostfs.info/TrueCloudLab/frostfs-node/internal/assert"
 	getsvc "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/object/get"
 	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/services/object/util"
 	"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/client"
@@ -38,9 +39,7 @@ func (s *TombstoneSourcePrm) SetGetService(v *getsvc.Service) {
 // Panics if any of the provided options does not allow
 // constructing a valid tombstone local Source.
 func NewSource(p TombstoneSourcePrm) Source {
-	if p.s == nil {
-		panic("Tombstone source: nil object service")
-	}
+	assert.False(p.s == nil, "Tombstone source: nil object service")
 
 	return Source(p)
 }
diff --git a/pkg/services/policer/policer.go b/pkg/services/policer/policer.go
index 4e8bacfec..d18b71a23 100644
--- a/pkg/services/policer/policer.go
+++ b/pkg/services/policer/policer.go
@@ -1,9 +1,11 @@
 package policer
 
 import (
+	"fmt"
 	"sync"
 	"time"
 
+	"git.frostfs.info/TrueCloudLab/frostfs-node/internal/assert"
 	oid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object/id"
 	lru "github.com/hashicorp/golang-lru/v2"
 	"go.uber.org/zap"
@@ -57,9 +59,7 @@ func New(opts ...Option) *Policer {
 	c.log = c.log.With(zap.String("component", "Object Policer"))
 
 	cache, err := lru.New[oid.Address, time.Time](int(c.cacheSize))
-	if err != nil {
-		panic(err)
-	}
+	assert.NoError(err, fmt.Sprintf("could not create LRU cache with %d size", c.cacheSize))
 
 	return &Policer{
 		cfg:   c,