[#536] blobovnicza: Drop cache

Each blobovnicza instance is opened
while is in use.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

pkg/local_object_storage/blobstor/blobovniczatree/control.go

@@ -2,11 +2,8 @@ package blobovniczatree
 
 import (
 	"context"
-	"fmt"
-	"path/filepath"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs"
-	"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/blobovnicza"
 	"go.uber.org/zap"
 )
 
@@ -14,6 +11,7 @@ import (
 func (b *Blobovniczas) Open(readOnly bool) error {
 	b.readOnly = readOnly
 	b.metrics.SetMode(readOnly)
+	b.openManagers()
 	return nil
 }
 
@@ -23,59 +21,35 @@ func (b *Blobovniczas) Open(readOnly bool) error {
 func (b *Blobovniczas) Init() error {
 	b.log.Debug(logs.BlobovniczatreeInitializingBlobovniczas)
 
+	b.openManagers()
+
 	if b.readOnly {
 		b.log.Debug(logs.BlobovniczatreeReadonlyModeSkipBlobovniczasInitialization)
 		return nil
 	}
 
 	return b.iterateLeaves(context.TODO(), func(p string) (bool, error) {
-		blz, err := b.openBlobovniczaNoCache(p)
+		shBlz := b.openBlobovniczaNoCache(p)
+		_, err := shBlz.Open()
 		if err != nil {
 			return true, err
 		}
-		defer blz.Close()
-
-		if err := blz.Init(); err != nil {
-			return true, fmt.Errorf("could not initialize blobovnicza structure %s: %w", p, err)
-		}
+		defer shBlz.Close()
 
 		b.log.Debug(logs.BlobovniczatreeBlobovniczaSuccessfullyInitializedClosing, zap.String("id", p))
 		return false, nil
 	})
 }
 
+func (b *Blobovniczas) openManagers() {
+	b.commondbManager.Open() //order important
+	b.activeDBManager.Open()
+}
+
 // Close implements common.Storage.
 func (b *Blobovniczas) Close() error {
-	b.activeMtx.Lock()
-
-	b.lruMtx.Lock()
-
-	for p, v := range b.active {
-		if err := v.blz.Close(); err != nil {
-			b.log.Debug(logs.BlobovniczatreeCouldNotCloseActiveBlobovnicza,
-				zap.String("path", p),
-				zap.String("error", err.Error()),
-			)
-		}
-		b.opened.Remove(p)
-	}
-	for _, k := range b.opened.Keys() {
-		blz, _ := b.opened.Get(k)
-		if err := blz.Close(); err != nil {
-			b.log.Debug(logs.BlobovniczatreeCouldNotCloseActiveBlobovnicza,
-				zap.String("path", k),
-				zap.String("error", err.Error()),
-			)
-		}
-		b.opened.Remove(k)
-	}
-
-	b.active = make(map[string]blobovniczaWithIndex)
-	b.metrics.Close()
-
-	b.lruMtx.Unlock()
-
-	b.activeMtx.Unlock()
+	b.activeDBManager.Close() //order important
+	b.commondbManager.Close()
 
 	return nil
 }
@@ -83,61 +57,10 @@ func (b *Blobovniczas) Close() error {
 // opens and returns blobovnicza with path p.
 //
 // If blobovnicza is already opened and cached, instance from cache is returned w/o changes.
-func (b *Blobovniczas) openBlobovnicza(p string) (*blobovnicza.Blobovnicza, error) {
-	b.lruMtx.Lock()
-	v, ok := b.opened.Get(p)
-	b.lruMtx.Unlock()
-	if ok {
-		// blobovnicza should be opened in cache
-		return v, nil
-	}
-
-	lvlPath := filepath.Dir(p)
-	curIndex := u64FromHexString(filepath.Base(p))
-
-	b.activeMtx.RLock()
-	defer b.activeMtx.RUnlock()
-
-	active, ok := b.active[lvlPath]
-	if ok && active.ind == curIndex {
-		return active.blz, nil
-	}
-
-	b.lruMtx.Lock()
-	defer b.lruMtx.Unlock()
-
-	v, ok = b.opened.Get(p)
-	if ok {
-		return v, nil
-	}
-
-	blz, err := b.openBlobovniczaNoCache(p)
-	if err != nil {
-		return nil, err
-	}
-
-	b.opened.Add(p, blz)
-
-	return blz, nil
+func (b *Blobovniczas) openBlobovnicza(p string) *sharedDB {
+	return b.openBlobovniczaNoCache(p)
 }
 
-func (b *Blobovniczas) openBlobovniczaNoCache(p string) (*blobovnicza.Blobovnicza, error) {
-	b.openMtx.Lock()
-	defer b.openMtx.Unlock()
-
-	path := filepath.Join(b.rootPath, p)
-
-	blz := blobovnicza.New(append(b.blzOpts,
-		blobovnicza.WithReadOnly(b.readOnly),
-		blobovnicza.WithPath(path),
-		blobovnicza.WithMetrics(b.metrics.Blobovnicza()),
-	)...)
-
-	if err := blz.Open(); err != nil {
-		return nil, fmt.Errorf("could not open blobovnicza %s: %w", p, err)
-	}
-	if err := blz.Init(); err != nil {
-		return nil, fmt.Errorf("could not init blobovnicza %s: %w", p, err)
-	}
-	return blz, nil
+func (b *Blobovniczas) openBlobovniczaNoCache(p string) *sharedDB {
+	return b.commondbManager.GetByPath(p)
 }