TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 107 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#12] cli: clarify -g usage in container list
All checks were successful
DCO action / DCO (pull_request) Successful in 7m44s
Details
Vulncheck / Vulncheck (pull_request) Successful in 9m38s
Details
Build / Build Components (1.21) (pull_request) Successful in 10m2s
Details
Build / Build Components (1.22) (pull_request) Successful in 10m0s
Details
Tests and linters / Staticcheck (pull_request) Successful in 12m36s
Details
Tests and linters / Lint (pull_request) Successful in 13m13s
Details
Tests and linters / gopls check (pull_request) Successful in 15m17s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 16m16s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 16m36s
Details
Tests and linters / Tests with -race (pull_request) Successful in 16m36s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 17m25s
Details

Browse source 
Add usage replacement for `container list -g` and verbose
warning when using `-g` without `--owner`.

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
This commit is contained in:
Ekaterina Lebedeva 2024-05-28 15:08:28 +03:00
parent 3627b44e92
commit cc3f762cf2
2 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
cmd/frostfs-cli/modules/container/list.go
View file

@ -18,6 +18,8 @@ const (
flagListPrintAttr = "with-attr"
flagListContainerOwner = "owner"
flagListName = "name"
generateKeyContainerUsage = commonflags.GenerateKeyUsage + ", should be used with --owner flag"
)
// flag vars of list command.
@ -34,6 +36,11 @@ var listContainersCmd = &cobra.Command{
Run: func(cmd *cobra.Command, _ []string) {
var idUser user.ID
generateKey, _ := cmd.Flags().GetBool(commonflags.GenerateKey)
if flagVarListContainerOwner == "" && generateKey {
cmd.PrintErrln("WARN: using -g without --owner - output will be empty")
}
key := key.GetOrGenerate(cmd)
if flagVarListContainerOwner == "" {
@ -104,4 +111,5 @@ func initContainerListContainersCmd() {
flags.BoolVar(&flagVarListPrintAttr, flagListPrintAttr, false,
"Request and print attributes of each container",
)
flags.Lookup(commonflags.GenerateKey).Usage = generateKeyContainerUsage
}