TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

[#2234] writecache: Fix possible panic in initFlushMarks

Browse source 
In case we have many small objects in the write-cache, `indices` should
not be reused between iterations.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
This commit is contained in:
Evgenii Stratonikov 2023-02-14 09:23:24 +03:00 committed by fyrchik
parent 315141dc2c
commit d1d123d180
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -37,6 +37,7 @@ Changelog for FrostFS Node
- Fix `*_req_count` and `*_req_count_success` metric values (#2241) - Fix `*_req_count` and `*_req_count_success` metric values (#2241)
- Storage ID update by write-cache (#2244) - Storage ID update by write-cache (#2244)
- `neo-go` client deadlock on subscription restoration (#2244) - `neo-go` client deadlock on subscription restoration (#2244)
- Possible panic during write-cache initialization (#2234)
### Removed ### Removed
### Updated ### Updated

1
pkg/local_object_storage/writecache/init.go
View file

@ -46,6 +46,7 @@ func (c *cache) initFlushMarks() {
var batchSize = flushBatchSize var batchSize = flushBatchSize
for { for {
m = m[:0] m = m[:0]
indices = indices[:0]
// We put objects in batches of fixed size to not interfere with main put cycle a lot. // We put objects in batches of fixed size to not interfere with main put cycle a lot.
_ = c.db.View(func(tx *bbolt.Tx) error { _ = c.db.View(func(tx *bbolt.Tx) error {