TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

[#668] shard/test: Do not alter rootPath option
All checks were successful
DCO action / DCO (pull_request) Successful in 4m14s
Details
Build / Build Components (1.21) (pull_request) Successful in 6m23s
Details
Build / Build Components (1.20) (pull_request) Successful in 7m11s
Details
Vulncheck / Vulncheck (pull_request) Successful in 6m40s
Details
Tests and linters / Lint (pull_request) Successful in 8m52s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 9m6s
Details
Tests and linters / Staticcheck (pull_request) Successful in 8m52s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 9m8s
Details
Tests and linters / Tests with -race (pull_request) Successful in 11m25s
Details

Browse source 
Supposedly, this was added to allow creating 2 different shards without
subtest. Now we use t.TempDir() everywhere, so this should not be a
problem.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
This commit is contained in:
Evgenii Stratonikov 2023-09-06 18:08:23 +03:00
parent 1c17a8a06e
commit d3ede98cd9
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/local_object_storage/shard/shard_test.go
View file

@ -54,7 +54,6 @@ func newCustomShard(t testing.TB, enableWriteCache bool, o shardOptions) *Shard
var sh *Shard var sh *Shard
if enableWriteCache { if enableWriteCache {
o.rootPath = filepath.Join(o.rootPath, "wc")
switch o.wcOpts.Type { switch o.wcOpts.Type {
case writecacheconfig.TypeBBolt: case writecacheconfig.TypeBBolt:
o.wcOpts.BBoltOptions = append( o.wcOpts.BBoltOptions = append(
@ -65,8 +64,6 @@ func newCustomShard(t testing.TB, enableWriteCache bool, o shardOptions) *Shard
[]writecachebadger.Option{writecachebadger.WithPath(filepath.Join(o.rootPath, "wcache"))}, []writecachebadger.Option{writecachebadger.WithPath(filepath.Join(o.rootPath, "wcache"))},
o.wcOpts.BadgerOptions...) o.wcOpts.BadgerOptions...)
} }
} else {
o.rootPath = filepath.Join(o.rootPath, "nowc")
} }
if o.bsOpts == nil { if o.bsOpts == nil {