TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

[#1351] apemanager: Fix AddChain handler for audit middleware
All checks were successful
DCO action / DCO (pull_request) Successful in 2m5s
Details
Build / Build Components (1.21) (pull_request) Successful in 2m45s
Details
Build / Build Components (1.22) (pull_request) Successful in 2m45s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m28s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m45s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 3m41s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m38s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 3m46s
Details
Tests and linters / Lint (pull_request) Successful in 4m6s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m2s
Details
Tests and linters / gopls check (pull_request) Successful in 4m21s
Details

Browse source 
* `GetChainID` from `frostfs-api-go/v2` does not handler nil-pointer
  response body that leads to the panic after its call.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
This commit is contained in:
Airat Arifullin 2024-09-04 15:57:34 +03:00
parent 43d6fbf73b
commit eec359cfa8
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/services/apemanager/audit.go
View file

@ -33,10 +33,15 @@ func (a *auditService) AddChain(ctx context.Context, req *apemanager.AddChainReq
return res, err return res, err
} }
var respChainID []byte
if respBody := res.GetBody(); respBody != nil {
respChainID = respBody.GetChainID()
}
audit.LogRequest(a.log, ape_grpc.APEManagerService_AddChain_FullMethodName, req, audit.LogRequest(a.log, ape_grpc.APEManagerService_AddChain_FullMethodName, req,
audit.TargetFromChainID(req.GetBody().GetTarget().GetTargetType().String(), audit.TargetFromChainID(req.GetBody().GetTarget().GetTargetType().String(),
req.GetBody().GetTarget().GetName(), req.GetBody().GetTarget().GetName(),
res.GetBody().GetChainID()), respChainID),
err == nil) err == nil)
return res, err return res, err