TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 13 Projects Releases 2 Activity Actions

[#1622] adm: Return non zero return code if metabase upgrade failed
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 35s
Details
DCO action / DCO (pull_request) Successful in 40s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m24s
Details
Build / Build Components (pull_request) Successful in 1m56s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m38s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m46s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m56s
Details
Tests and linters / Tests (pull_request) Successful in 2m58s
Details
Tests and linters / gopls check (pull_request) Successful in 3m9s
Details
Tests and linters / Lint (pull_request) Successful in 3m23s
Details

Browse source 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2025-01-30 15:29:38 +03:00
parent 74e11b3cf3
commit f43ee57b9b
Signed by: dstepanov-yadro
GPG key ID: 237AF1A763293BC0
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cmd/frostfs-adm/internal/modules/metabase/upgrade.go
View file

@ -28,6 +28,7 @@ const (
var ( var (
errNoPathsFound = errors.New("no metabase paths found") errNoPathsFound = errors.New("no metabase paths found")
errNoMorphEndpointsFound = errors.New("no morph endpoints found") errNoMorphEndpointsFound = errors.New("no morph endpoints found")
errUpgradeFailed = errors.New("upgrade failed")
) )
var UpgradeCmd = &cobra.Command{ var UpgradeCmd = &cobra.Command{
@ -91,14 +92,19 @@ func upgrade(cmd *cobra.Command, _ []string) error {
if err := eg.Wait(); err != nil { if err := eg.Wait(); err != nil {
return err return err
} }
allSuccess := true
for mb, ok := range result { for mb, ok := range result {
if ok { if ok {
cmd.Println(mb, ": success") cmd.Println(mb, ": success")
} else { } else {
cmd.Println(mb, ": failed") cmd.Println(mb, ": failed")
allSuccess = false
} }
} }
if allSuccess {
return nil return nil
}
return errUpgradeFailed
} }
func getMetabasePaths(appCfg *config.Config) ([]string, error) { func getMetabasePaths(appCfg *config.Config) ([]string, error) {