TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

[#1357] go: Fix panic caused by using range over slice len
All checks were successful
Vulncheck / Vulncheck (pull_request) Successful in 1m12s
Details
DCO action / DCO (pull_request) Successful in 1m28s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m53s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m55s
Details
Build / Build Components (pull_request) Successful in 2m14s
Details
Tests and linters / gopls check (pull_request) Successful in 2m22s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m30s
Details
Tests and linters / Lint (pull_request) Successful in 3m15s
Details
Tests and linters / Tests (pull_request) Successful in 3m25s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m31s
Details

Browse source 
If slice is altered in `for` loop, we cannot use range over its
length: it may cause panic if slice gets shorter.

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
This commit is contained in:
Ekaterina Lebedeva 2024-09-06 13:09:58 +03:00
parent 273980cfb9
commit f652518c24
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/services/control/server/evacuate.go
View file

@ -169,7 +169,7 @@ func (s *Server) getContainerNodes(contID cid.ID) ([]netmap.NodeInfo, error) {
nodes := placement.FlattenNodes(ns) nodes := placement.FlattenNodes(ns)
bs := (*keys.PublicKey)(&s.key.PublicKey).Bytes() bs := (*keys.PublicKey)(&s.key.PublicKey).Bytes()
for i := range len(nodes) { for i := 0; i < len(nodes); i++ { // don't use range, slice mutates in body
if bytes.Equal(nodes[i].PublicKey(), bs) { if bytes.Equal(nodes[i].PublicKey(), bs) {
copy(nodes[i:], nodes[i+1:]) copy(nodes[i:], nodes[i+1:])
nodes = nodes[:len(nodes)-1] nodes = nodes[:len(nodes)-1]