TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 109 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#1653] blobstor: Add IO tag label to metrics

Browse source 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2025-02-18 11:23:10 +03:00
parent 3a6a58b163
commit fae4040433
Signed by: dstepanov-yadro
GPG key ID: 237AF1A763293BC0
12 changed files with 65 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

7
internal/metrics/blobstore.go
View file

@ -12,7 +12,7 @@ type BlobstoreMetrics interface {
SetMode(shardID string, readOnly bool)
Close(shardID string)
MethodDuration(shardID string, method string, d time.Duration, success bool, withStorageID NullBool)
MethodDuration(shardID string, method string, d time.Duration, success bool, withStorageID NullBool, ioTag string)
AddPut(shardID string, size int)
AddGet(shardID string, size int)
}
@ -32,7 +32,7 @@ func newBlobstoreMetrics() *blobstoreMetrics {
Subsystem: blobstoreSubSystem,
Name: "request_duration_seconds",
Help: "Accumulated Blobstore request process duration",
}, []string{shardIDLabel, successLabel, methodLabel, withStorageIDLabel}),
}, []string{shardIDLabel, successLabel, methodLabel, withStorageIDLabel, ioTagLabel}),
put: metrics.NewCounterVec(prometheus.CounterOpts{
Namespace: namespace,
Subsystem: blobstoreSubSystem,
@ -65,12 +65,13 @@ func (m *blobstoreMetrics) Close(shardID string) {
})
}
func (m *blobstoreMetrics) MethodDuration(shardID string, method string, d time.Duration, success bool, withStorageID NullBool) {
func (m *blobstoreMetrics) MethodDuration(shardID string, method string, d time.Duration, success bool, withStorageID NullBool, ioTag string) {
m.reqDuration.With(prometheus.Labels{
shardIDLabel: shardID,
successLabel: strconv.FormatBool(success),
methodLabel: method,
withStorageIDLabel: withStorageID.String(),
ioTagLabel: ioTag,
}).Observe(d.Seconds())
}