[#156] shard: Make refillMetabase() pass linter checks

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

pkg/local_object_storage/shard/control.go

@@ -155,7 +155,6 @@ func (s *Shard) Init() error {
 	return nil
 }
 
-// nolint: funlen
 func (s *Shard) refillMetabase() error {
 	err := s.metaBase.Reset()
 	if err != nil {
@@ -172,9 +171,60 @@ func (s *Shard) refillMetabase() error {
 			return nil
 		}
 
-		// nolint: exhaustive
+		var err error
 		switch obj.Type() {
 		case objectSDK.TypeTombstone:
+			err = s.refillTombstoneObject(obj)
+		case objectSDK.TypeLock:
+			err = s.refillLockObject(obj)
+		default:
+		}
+		if err != nil {
+			return err
+		}
+
+		var mPrm meta.PutPrm
+		mPrm.SetObject(obj)
+		mPrm.SetStorageID(descriptor)
+
+		_, err = s.metaBase.Put(mPrm)
+		if err != nil && !meta.IsErrRemoved(err) && !errors.Is(err, meta.ErrObjectIsExpired) {
+			return err
+		}
+
+		return nil
+	})
+	if err != nil {
+		return fmt.Errorf("could not put objects to the meta: %w", err)
+	}
+
+	err = s.metaBase.SyncCounters()
+	if err != nil {
+		return fmt.Errorf("could not sync object counters: %w", err)
+	}
+
+	return nil
+}
+
+func (s *Shard) refillLockObject(obj *objectSDK.Object) error {
+	var lock objectSDK.Lock
+	if err := lock.Unmarshal(obj.Payload()); err != nil {
+		return fmt.Errorf("could not unmarshal lock content: %w", err)
+	}
+
+	locked := make([]oid.ID, lock.NumberOfMembers())
+	lock.ReadMembers(locked)
+
+	cnr, _ := obj.ContainerID()
+	id, _ := obj.ID()
+	err := s.metaBase.Lock(cnr, id, locked)
+	if err != nil {
+		return fmt.Errorf("could not lock objects: %w", err)
+	}
+	return nil
+}
+
+func (s *Shard) refillTombstoneObject(obj *objectSDK.Object) error {
 	tombstone := objectSDK.NewTombstone()
 
 	if err := tombstone.Unmarshal(obj.Payload()); err != nil {
@@ -197,47 +247,10 @@ func (s *Shard) refillMetabase() error {
 	inhumePrm.SetTombstoneAddress(tombAddr)
 	inhumePrm.SetAddresses(tombMembers...)
 
-			_, err = s.metaBase.Inhume(inhumePrm)
+	_, err := s.metaBase.Inhume(inhumePrm)
 	if err != nil {
 		return fmt.Errorf("could not inhume objects: %w", err)
 	}
-		case objectSDK.TypeLock:
-			var lock objectSDK.Lock
-			if err := lock.Unmarshal(obj.Payload()); err != nil {
-				return fmt.Errorf("could not unmarshal lock content: %w", err)
-			}
-
-			locked := make([]oid.ID, lock.NumberOfMembers())
-			lock.ReadMembers(locked)
-
-			cnr, _ := obj.ContainerID()
-			id, _ := obj.ID()
-			err = s.metaBase.Lock(cnr, id, locked)
-			if err != nil {
-				return fmt.Errorf("could not lock objects: %w", err)
-			}
-		}
-
-		var mPrm meta.PutPrm
-		mPrm.SetObject(obj)
-		mPrm.SetStorageID(descriptor)
-
-		_, err := s.metaBase.Put(mPrm)
-		if err != nil && !meta.IsErrRemoved(err) && !errors.Is(err, meta.ErrObjectIsExpired) {
-			return err
-		}
-
-		return nil
-	})
-	if err != nil {
-		return fmt.Errorf("could not put objects to the meta: %w", err)
-	}
-
-	err = s.metaBase.SyncCounters()
-	if err != nil {
-		return fmt.Errorf("could not sync object counters: %w", err)
-	}
-
 	return nil
 }