TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 107 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#1598] golangci: Enable unparam linter
All checks were successful
DCO action / DCO (pull_request) Successful in 35s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m6s
Details
Build / Build Components (pull_request) Successful in 1m45s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m44s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m59s
Details
Tests and linters / gopls check (pull_request) Successful in 2m19s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m35s
Details
Tests and linters / Lint (pull_request) Successful in 2m56s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m48s
Details
Tests and linters / Tests (pull_request) Successful in 3m58s
Details

Browse source 
To drop unnecessary parameters and return values.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2025-01-13 17:43:39 +03:00
parent 4d5ae59a52
commit fb928616cc
Signed by: dstepanov-yadro
GPG key ID: 237AF1A763293BC0
26 changed files with 123 additions and 155 deletions
Download patch file Download diff file Expand all files Collapse all files

9
pkg/services/object_manager/placement/traverser.go
View file

@ -120,10 +120,7 @@ func NewTraverser(opts ...Option) (*Traverser, error) {
}
rem = []int{-1, -1}
sortedVector, err := sortVector(cfg, unsortedVector)
if err != nil {
return nil, err
}
sortedVector := sortVector(cfg, unsortedVector)
ns = [][]netmap.NodeInfo{sortedVector, regularVector}
} else if cfg.flatSuccess != nil {
ns = flatNodes(ns)
@ -188,7 +185,7 @@ type nodeMetrics struct {
metrics []int
}
func sortVector(cfg *cfg, unsortedVector []netmap.NodeInfo) ([]netmap.NodeInfo, error) {
func sortVector(cfg *cfg, unsortedVector []netmap.NodeInfo) []netmap.NodeInfo {
nm := make([]nodeMetrics, len(unsortedVector))
node := cfg.nodeState.LocalNodeInfo()
@ -209,7 +206,7 @@ func sortVector(cfg *cfg, unsortedVector []netmap.NodeInfo) ([]netmap.NodeInfo,
for i := range unsortedVector {
sortedVector[i] = unsortedVector[nm[i].index]
}
return sortedVector, nil
return sortedVector
}
// Node is a descriptor of storage node with information required for intra-container communication.