neofs-adm should take network settings into account during contract update #100

New issue

Closed

opened 2023-03-08 23:33:48 +00:00 by snegurochka · 0 comments

snegurochka commented

2023-03-08 23:33:48 +00:00

Member

Original issue: https://github.com/nspcc-dev/neofs-node/issues/2191

Expected Behavior

neofs-adm morph update-contracts taking wallets/contracts/RPC parameters and doing its job.

Current Behavior

On netmap contract upgrade any network settings are overwritten with some default ones unless they're given as a part of environment/config.

Possible Solution

If we're upgrading we already have some network and it already has some parameters, so the tool should just take (via RPC) and use them, except for parameters that are new and where default values are to be used.

Steps to Reproduce (for bugs)

neofs-adm morph update-contracts --alphabet-wallets ... --contracts ... -r

Context

Mainnet upgrade.

Your Environment

v0.34.0

Original issue: https://github.com/nspcc-dev/neofs-node/issues/2191 ## Expected Behavior `neofs-adm morph update-contracts` taking wallets/contracts/RPC parameters and doing its job. ## Current Behavior On netmap contract upgrade any network settings are overwritten with some default ones unless they're given as a part of environment/config. ## Possible Solution If we're upgrading we already have some network and it already has some parameters, so the tool should just take (via RPC) and use them, except for parameters that are new and where default values are to be used. ## Steps to Reproduce (for bugs) 1. `neofs-adm morph update-contracts --alphabet-wallets ... --contracts ... -r` ## Context Mainnet upgrade. ## Your Environment v0.34.0