Setting `opened_cache_ttl` in any section of 99_config.yaml doesn't applicable #1002

New issue

Closed

opened 2024-02-21 12:55:05 +00:00 by anikeev-yadro · 3 comments

anikeev-yadro commented

2024-02-21 12:55:05 +00:00

Member

Expected Behavior

Setting opened_cache_ttl in default or shard:0 section of 99_config.yaml should applicable

Current Behavior

Setting opened_cache_ttl in default or shard:0 section of config.yaml doesn't applicable

Steps to Reproduce (for bugs)

1.Set parameter in default section in file /etc/frostfs/storage/conf.d/99_storage.yml

storage:
  shard:
    default: # section with the default shard parameters
      blobstor:
          opened_cache_ttl: 5m  # ttl for opened database file
          opened_cache_capacity: 17
logger:
  level: debug
  destination: journald

2.Restart frostfs-storage and see that this parameter is not applicable
3.Setting parameter in shard:0 section in file /etc/frostfs/storage/conf.d/99_storage.yml

storage:
  shard:
    0:
      mode: 'read-write'
      blobstore:
          opened_cache_ttl: 1m
          opened_cache_capacity: 18

4.Restart frostfs-storage and see that this parameter is not applicable

Regression

Version

FrostFS Storage node
Version: v0.37.0-rc.1-322-g2680192b
GoVersion: go1.20.1

Your Environment

Cloud

## Expected Behavior Setting `opened_cache_ttl` in `default` or `shard:0` section of `99_config.yaml` should applicable ## Current Behavior Setting `opened_cache_ttl` in `default` or `shard:0` section of `config.yaml` doesn't applicable ## Steps to Reproduce (for bugs) 1.Set parameter in `default` section in file ` /etc/frostfs/storage/conf.d/99_storage.yml` ``` storage: shard: default: # section with the default shard parameters blobstor: opened_cache_ttl: 5m # ttl for opened database file opened_cache_capacity: 17 logger: level: debug destination: journald ``` 2.Restart frostfs-storage and see that this parameter is not applicable 3.Setting parameter in shard:0 section in file ` /etc/frostfs/storage/conf.d/99_storage.yml` ``` storage: shard: 0: mode: 'read-write' blobstore: opened_cache_ttl: 1m opened_cache_capacity: 18 ``` 4.Restart frostfs-storage and see that this parameter is not applicable ## Regression No ## Version ``` FrostFS Storage node Version: v0.37.0-rc.1-322-g2680192b GoVersion: go1.20.1 ``` ## Your Environment Cloud

Downloads.zip

2.7 KiB

anikeev-yadro added the

bug

triage

labels 2024-02-21 12:55:05 +00:00

fyrchik commented

2024-02-21 13:12:17 +00:00

Owner

I am not sure it should be in this section, the correct one seems to be storage.shard.default.blobstor.0 (notice then ending .0)
cc @acid-ant

I am not sure it should be in this section, the correct one seems to be `storage.shard.default.blobstor.0` (notice then ending `.0`) cc @acid-ant

acid-ant self-assigned this 2024-02-21 13:16:53 +00:00

acid-ant commented

2024-02-21 13:21:24 +00:00

Member

@fyrchik this issue is more about investigation how parameters from default section are applied. Expect that opened_cache_ttl will have the same behavior as opened_cache_capacity, which is present in default too but not applied from this section.

@fyrchik this issue is more about investigation how parameters from `default` section are applied. Expect that `opened_cache_ttl` will have the same behavior as `opened_cache_capacity`, which is [present](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/config/example/node.yaml#L152) in default too but not applied from this section.

👍 1