engine: Drop shards weights #1005

dstepanov-yadro · 2024-02-26T08:27:44Z

dstepanov-yadro commented

2024-02-26 08:27:44 +00:00

Now Shard.FreeSpace is always 0, so weights are unused
Shard.FreeSpace is not the best weight metric
Using weights requires redundant memory allocations

- Now `Shard.FreeSpace` is always 0, so weights are unused - `Shard.FreeSpace` is not the best weight metric - Using weights requires redundant memory allocations

dstepanov-yadro force-pushed feat/drop_shard_weight from 9e1edd70b7 to b250b9e8de

2024-02-26 08:28:35 +00:00

Compare

dstepanov-yadro requested review from storage-core-committers 2024-02-26 08:43:10 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-02-26 08:43:11 +00:00

acid-ant approved these changes 2024-02-26 08:56:16 +00:00

fyrchik approved these changes 2024-02-26 10:59:29 +00:00

fyrchik left a comment

Can we make an additional test here? (expect it to pass).

Sort with 0 weights
SortHasherSliceByValue
Ensure that the order is the same.

If it is not, we can slowdown on update.

Can we make an additional test here? (expect it to pass). 1. Sort with 0 weights 2. `SortHasherSliceByValue` 3. Ensure that the order is the same. If it is not, we can slowdown on update.

fyrchik reviewed 2024-02-26 11:00:24 +00:00

pkg/local_object_storage/shard/info.go Outdated

													
				@ -26,4 +26,2 @@

					WriteCacheInfo writecache.Info

					// Weight parameters of the shard.

					WeightValues WeightValues

fyrchik commented

2024-02-26 11:00:24 +00:00

Could affect frostfs-testcases, do we output this in frostfs-cli?

dstepanov-yadro commented

2024-02-26 14:18:49 +00:00

Poster

There is no weights in shard info.

👍 1

fyrchik marked this conversation as resolved

dstepanov-yadro force-pushed feat/drop_shard_weight from b250b9e8de to 2ad433dbcb

2024-02-26 14:25:36 +00:00

Compare

dstepanov-yadro commented

2024-02-26 14:26:25 +00:00

Poster

Can we make an additional test here? (expect it to pass).

Sort with 0 weights

SortHasherSliceByValue

Ensure that the order is the same.

If it is not, we can slowdown on update.

Done

> Can we make an additional test here? (expect it to pass). > 1. Sort with 0 weights > 2. `SortHasherSliceByValue` > 3. Ensure that the order is the same. > > If it is not, we can slowdown on update. Done

acid-ant approved these changes 2024-02-26 16:06:52 +00:00

fyrchik approved these changes 2024-02-26 16:08:23 +00:00

fyrchik merged commit 2ad433dbcb into master

2024-02-26 16:08:31 +00:00

fyrchik referenced this issue from a commit

2024-02-26 16:08:33 +00:00

[#1005] engine: Drop shards weights

Sign in to join this conversation.

No reviewers