Add writecache inhume tests #1028

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/writecache_consistency into master 2024-09-04 19:51:07 +00:00

Closes #634

See issue for details.

  1. Delete method for writecache called only by shard.Inhume, so there are two possible ways:
  • object was flushed to blobstore before shard.Inhume, so GC will eventually delete this object from metabase and blobstore
  • object was deleted from writecache during shard.Inhume, then GC will eventually delete this object from metabase only
    GC will skip object from deletion if writecache stores this object.

I have added unit tests for this.

  1. Writecache has specific usage, so objectID is hash of object's payload and headers. So having the same objectID with different payloads is almost impossible.
Closes #634 See issue for details. 1. `Delete` method for writecache called only by `shard.Inhume`, so there are two possible ways: - object was flushed to blobstore before `shard.Inhume`, so GC will eventually delete this object from metabase and blobstore - object was deleted from writecache during `shard.Inhume`, then GC will eventually delete this object from metabase only GC will skip object from deletion if writecache stores this object. I have added unit tests for this. 2. Writecache has specific usage, so objectID is hash of object's payload and headers. So having the same objectID with different payloads is almost impossible.
fyrchik approved these changes 2024-03-06 09:55:31 +00:00
dstepanov-yadro force-pushed fix/writecache_consistency from d627c2e4a2 to 26924671e1 2024-03-06 10:05:51 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-03-06 10:10:39 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-03-06 10:10:42 +00:00
acid-ant approved these changes 2024-03-06 10:12:09 +00:00
dstepanov-yadro force-pushed fix/writecache_consistency from 26924671e1 to 63a29110ee 2024-03-06 10:12:51 +00:00 Compare
acid-ant approved these changes 2024-03-06 10:17:34 +00:00
fyrchik merged commit 63a29110ee into master 2024-03-06 10:42:50 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1028
No description provided.