ape: Remove all chains by target #1031

Merged
acid-ant merged 1 commit from acid-ant/frostfs-node:feature/976-remove-all-rules into master 2024-09-04 19:51:07 +00:00
Member

Close #976

Allow removing all chains by target via cli and adm.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #976 Allow removing all chains by target via `cli` and `adm`. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant force-pushed feature/976-remove-all-rules from 0d8c693cef to 3f52d6f5e7 2024-03-07 16:23:10 +00:00 Compare
acid-ant requested review from storage-core-committers 2024-03-07 16:34:44 +00:00
acid-ant requested review from storage-core-developers 2024-03-07 16:34:45 +00:00
dstepanov-yadro approved these changes 2024-03-11 12:56:05 +00:00
acid-ant force-pushed feature/976-remove-all-rules from 3f52d6f5e7 to f8e0ffd857 2024-03-11 18:45:05 +00:00 Compare
acid-ant force-pushed feature/976-remove-all-rules from 88b30a42c2 to 88385657cb 2024-03-12 08:41:35 +00:00 Compare
acid-ant requested review from dstepanov-yadro 2024-03-12 08:42:50 +00:00
fyrchik reviewed 2024-03-12 09:49:38 +00:00
@ -50,3 +51,3 @@
flags := evacuateShardCmd.Flags()
flags.StringSlice(shardIDFlag, nil, "List of shard IDs in base58 encoding")
flags.Bool(shardAllFlag, false, "Process all shards")
flags.Bool(commonflags.AllFlag, false, "Process all shards")
Owner

I don't think it is necessary to do deduplication for such simple flags, they have different meaning in different commands, the correspondence in name is accidental.

I don't think it is necessary to do deduplication for such simple flags, they have different meaning in different commands, the correspondence in name is accidental.
Author
Member

Don't mind. Changes were reverted.

Don't mind. Changes were reverted.
acid-ant force-pushed feature/976-remove-all-rules from 88385657cb to 1a33f786f1 2024-03-12 10:44:13 +00:00 Compare
acid-ant force-pushed feature/976-remove-all-rules from 1a33f786f1 to 2cf483d2c8 2024-03-12 10:48:35 +00:00 Compare
acid-ant force-pushed feature/976-remove-all-rules from 2cf483d2c8 to a4e9484be4 2024-03-12 18:25:57 +00:00 Compare
acid-ant force-pushed feature/976-remove-all-rules from a4e9484be4 to 7f8ca6f45c 2024-03-13 12:01:32 +00:00 Compare
acid-ant force-pushed feature/976-remove-all-rules from 7f8ca6f45c to fb9219af39 2024-03-13 12:33:57 +00:00 Compare
dstepanov-yadro approved these changes 2024-03-13 13:01:59 +00:00
fyrchik approved these changes 2024-03-13 18:01:36 +00:00
acid-ant merged commit fb9219af39 into master 2024-03-13 18:35:23 +00:00
acid-ant deleted branch feature/976-remove-all-rules 2024-03-13 18:35:24 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1031
No description provided.