TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 90 Pull requests 4 Projects Releases 1 Activity Actions

WIP: object: Ignore APE check for PutSingle with tombstone object #1051

Closed
aarifullin wants to merge 1 commit from aarifullin/frostfs-node:fix/object_ape_ignore_tombstone into master
pull from: aarifullin/frostfs-node:fix/object_ape_ignore_tombstone
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +5
aarifullin commented 2024-03-19 11:44:27 +00:00
Member
Copy link
  • When a client requests DeleteObject, delete service may send PutSingle with tombstone object type to several nodes. If APE allows deletes, but denies puts, then PutSingle cannot be performed although it is being performed in the delete context. So, check for putting tombstone is ignored.

cc @dkirillov

* When a client requests DeleteObject, delete service may send PutSingle with tombstone object type to several nodes. If APE allows deletes, but denies puts, then PutSingle cannot be performed although it is being performed in the delete context. So, check for putting tombstone is ignored. cc @dkirillov
aarifullin added the
bug
discussion
 labels 2024-03-19 11:44:27 +00:00
aarifullin requested review from storage-core-committers 2024-03-19 11:44:38 +00:00
aarifullin requested review from storage-core-developers 2024-03-19 11:44:38 +00:00
aarifullin force-pushed fix/object_ape_ignore_tombstone from fcec701f7d to 740cfe4ac1 2024-03-19 11:46:01 +00:00 Compare
fyrchik reviewed 2024-03-19 11:52:32 +00:00
pkg/services/object/ape/checker.go
@ -78,2 +78,4 @@
}
if prm.Method == nativeschema.MethodPutObject &&
r.Resource().Property(nativeschema.PropertyKeyObjectType) == objectV2.TypeTombstone.String() {
fyrchik commented 2024-03-19 11:52:31 +00:00
Owner
Copy link

So anyone can delete any object?

So anyone can delete any object?
aarifullin commented 2024-03-19 15:11:36 +00:00
Author
Member
Copy link

This approach need to be reconsidered...

This approach need to be reconsidered...
fyrchik changed title from object: Ignore APE check for PutSingle with tombstone object to WIP: object: Ignore APE check for PutSingle with tombstone object 2024-03-20 06:02:07 +00:00
fyrchik closed this pull request 2024-03-27 09:06:40 +00:00
Some checks failed
Tests and linters / Tests with -race (pull_request) Failing after 4m21s
Required
Details
DCO action / DCO (pull_request) Successful in 6m58s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 6m58s
Required
Details
Build / Build Components (1.21) (pull_request) Successful in 9m31s
Required
Details
Build / Build Components (1.20) (pull_request) Successful in 9m44s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 10m4s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 10m21s
Required
Details
Tests and linters / Lint (pull_request) Successful in 11m48s
Required
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 13m18s
Required
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 13m18s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1051
No description provided.
Delete branch "aarifullin/frostfs-node:fix/object_ape_ignore_tombstone"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?