WIP: object: Ignore APE check for PutSingle with tombstone object #1051

Closed
aarifullin wants to merge 1 commit from aarifullin/frostfs-node:fix/object_ape_ignore_tombstone into master
Member
  • When a client requests DeleteObject, delete service may send PutSingle with tombstone object type to several nodes. If APE allows deletes, but denies puts, then PutSingle cannot be performed although it is being performed in the delete context. So, check for putting tombstone is ignored.

cc @dkirillov

* When a client requests DeleteObject, delete service may send PutSingle with tombstone object type to several nodes. If APE allows deletes, but denies puts, then PutSingle cannot be performed although it is being performed in the delete context. So, check for putting tombstone is ignored. cc @dkirillov
aarifullin added the
bug
discussion
labels 2024-03-19 11:44:27 +00:00
aarifullin requested review from storage-core-committers 2024-03-19 11:44:38 +00:00
aarifullin requested review from storage-core-developers 2024-03-19 11:44:38 +00:00
aarifullin force-pushed fix/object_ape_ignore_tombstone from fcec701f7d to 740cfe4ac1 2024-03-19 11:46:01 +00:00 Compare
fyrchik reviewed 2024-03-19 11:52:32 +00:00
@ -78,2 +78,4 @@
}
if prm.Method == nativeschema.MethodPutObject &&
r.Resource().Property(nativeschema.PropertyKeyObjectType) == objectV2.TypeTombstone.String() {
Owner

So anyone can delete any object?

So anyone can delete any object?
Author
Member

This approach need to be reconsidered...

This approach need to be reconsidered...
fyrchik changed title from object: Ignore APE check for PutSingle with tombstone object to WIP: object: Ignore APE check for PutSingle with tombstone object 2024-03-20 06:02:07 +00:00
fyrchik closed this pull request 2024-03-27 09:06:40 +00:00
Some checks failed
Tests and linters / Tests with -race (pull_request) Failing after 4m21s
Required
Details
DCO action / DCO (pull_request) Successful in 6m58s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 6m58s
Required
Details
Build / Build Components (1.21) (pull_request) Successful in 9m31s
Required
Details
Build / Build Components (1.20) (pull_request) Successful in 9m44s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 10m4s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 10m21s
Required
Details
Tests and linters / Lint (pull_request) Successful in 11m48s
Required
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 13m18s
Required
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 13m18s
Required
Details

Pull request closed

Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1051
No description provided.