TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

Metric of frostfs_node_blobstore_mode is always CLOSED #1055

New issue
Closed
opened 2024-03-26 06:18:52 +00:00 by anikeev-yadro · 0 comments
anikeev-yadro commented 2024-03-26 06:18:52 +00:00
Member
Copy link

Expected Behavior

Metric should contains actual mode.

Current Behavior

Metric of frostfs_node_blobstore_mode is always CLOSED

Steps to Reproduce (for bugs)

1.Move shard to read-only

root@aanikeev-node1[alone_datacenter]:~# frostfs-cli --id V6uMDX8pJ5WYQEtVrYhA2E  --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json --config /tmp/storage.yaml control shards set-mode --mode='read-only'
Shard mode update request successfully sent.
root@aanikeev-node1[alone_datacenter]:~# frostfs-cli  --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json --config /tmp/storage.yaml control shards list|grep -i mode
Mode: read-write
Mode: read-write
Mode: read-write
Mode: read-write
Mode: read-write
Mode: read-only

2.See that metric frostfs_node_blobstore_mode="CLOSED"

root@aanikeev-node1[alone_datacenter]:~# curl -s localhost:6672 | grep blob|grep mode
# HELP frostfs_node_blobovnicza_tree_mode Blobovnicza tree mode
# TYPE frostfs_node_blobovnicza_tree_mode gauge
frostfs_node_blobovnicza_tree_mode{mode="READ_ONLY",path="/srv/frostfs/data/493d7d49/data/blobovnicza",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/1a4724e1/data/blobovnicza",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/5d3b73b3/data/blobovnicza",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/9d362559/data/blobovnicza",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/f4ddd21e/data/blobovnicza",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/f54b4cc0/data/blobovnicza",shard_id="9rCZunixYKndMqnep1xNfm"} 1
# HELP frostfs_node_blobstore_mode Blobstore mode value
# TYPE frostfs_node_blobstore_mode gauge
frostfs_node_blobstore_mode{mode="CLOSED",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="9rCZunixYKndMqnep1xNfm"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1

3.Move shard to RW mode and see that metric was not changed

root@aanikeev-node1[alone_datacenter]:~# curl -s localhost:6672 | grep blob|grep mode
# HELP frostfs_node_blobovnicza_tree_mode Blobovnicza tree mode
# TYPE frostfs_node_blobovnicza_tree_mode gauge
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/1a4724e1/data/blobovnicza",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/493d7d49/data/blobovnicza",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/5d3b73b3/data/blobovnicza",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/9d362559/data/blobovnicza",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/f4ddd21e/data/blobovnicza",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/f54b4cc0/data/blobovnicza",shard_id="9rCZunixYKndMqnep1xNfm"} 1
frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/1a4724e1/data/blobovnicza",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1
frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/5d3b73b3/data/blobovnicza",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1
frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/9d362559/data/blobovnicza",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1
frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/f4ddd21e/data/blobovnicza",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1
frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/f54b4cc0/data/blobovnicza",shard_id="9rCZunixYKndMqnep1xNfm"} 1
frostfs_node_blobovnicza_tree_rebuild_status{mode="not_started",path="/srv/frostfs/data/493d7d49/data/blobovnicza",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1
# HELP frostfs_node_blobstore_mode Blobstore mode value
# TYPE frostfs_node_blobstore_mode gauge
frostfs_node_blobstore_mode{mode="CLOSED",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="9rCZunixYKndMqnep1xNfm"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1
frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1

Regression

No

Version

FrostFS Storage node
Version: v0.38.1
GoVersion: go1.22.0

Your Environment

Vitrual

<!-- Provide a general summary of the issue in the Title above --> ## Expected Behavior Metric should contains actual mode. ## Current Behavior Metric of `frostfs_node_blobstore_mode` is always CLOSED ## Steps to Reproduce (for bugs) 1.Move shard to `read-only` ``` root@aanikeev-node1[alone_datacenter]:~# frostfs-cli --id V6uMDX8pJ5WYQEtVrYhA2E --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json --config /tmp/storage.yaml control shards set-mode --mode='read-only' Shard mode update request successfully sent. root@aanikeev-node1[alone_datacenter]:~# frostfs-cli --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json --config /tmp/storage.yaml control shards list|grep -i mode Mode: read-write Mode: read-write Mode: read-write Mode: read-write Mode: read-write Mode: read-only ``` 2.See that metric `frostfs_node_blobstore_mode="CLOSED"` ``` root@aanikeev-node1[alone_datacenter]:~# curl -s localhost:6672 | grep blob|grep mode # HELP frostfs_node_blobovnicza_tree_mode Blobovnicza tree mode # TYPE frostfs_node_blobovnicza_tree_mode gauge frostfs_node_blobovnicza_tree_mode{mode="READ_ONLY",path="/srv/frostfs/data/493d7d49/data/blobovnicza",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/1a4724e1/data/blobovnicza",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/5d3b73b3/data/blobovnicza",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/9d362559/data/blobovnicza",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/f4ddd21e/data/blobovnicza",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/f54b4cc0/data/blobovnicza",shard_id="9rCZunixYKndMqnep1xNfm"} 1 # HELP frostfs_node_blobstore_mode Blobstore mode value # TYPE frostfs_node_blobstore_mode gauge frostfs_node_blobstore_mode{mode="CLOSED",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="9rCZunixYKndMqnep1xNfm"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1 ``` 3.Move shard to RW mode and see that metric was not changed ``` root@aanikeev-node1[alone_datacenter]:~# curl -s localhost:6672 | grep blob|grep mode # HELP frostfs_node_blobovnicza_tree_mode Blobovnicza tree mode # TYPE frostfs_node_blobovnicza_tree_mode gauge frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/1a4724e1/data/blobovnicza",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/493d7d49/data/blobovnicza",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/5d3b73b3/data/blobovnicza",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/9d362559/data/blobovnicza",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/f4ddd21e/data/blobovnicza",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1 frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data/f54b4cc0/data/blobovnicza",shard_id="9rCZunixYKndMqnep1xNfm"} 1 frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/1a4724e1/data/blobovnicza",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1 frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/5d3b73b3/data/blobovnicza",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1 frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/9d362559/data/blobovnicza",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1 frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/f4ddd21e/data/blobovnicza",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1 frostfs_node_blobovnicza_tree_rebuild_status{mode="completed",path="/srv/frostfs/data/f54b4cc0/data/blobovnicza",shard_id="9rCZunixYKndMqnep1xNfm"} 1 frostfs_node_blobovnicza_tree_rebuild_status{mode="not_started",path="/srv/frostfs/data/493d7d49/data/blobovnicza",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1 # HELP frostfs_node_blobstore_mode Blobstore mode value # TYPE frostfs_node_blobstore_mode gauge frostfs_node_blobstore_mode{mode="CLOSED",shard_id="V6uMDX8pJ5WYQEtVrYhA2E"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="7JPTtEcnAVgRVEe1GyQvcH"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="9rCZunixYKndMqnep1xNfm"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="AAJ6uz1nq8GhTB4dNoajfM"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="Fx6nAsonXKjXq4dtb2JFik"} 1 frostfs_node_blobstore_mode{mode="READ_WRITE",shard_id="KYxBAHsVg4Sr9WTD8D8x7h"} 1 ``` ## Regression No ## Version ``` FrostFS Storage node Version: v0.38.1 GoVersion: go1.22.0 ``` ## Your Environment Vitrual
anikeev-yadro added the
bug
triage
 labels 2024-03-26 06:18:52 +00:00
elebedeva was assigned by acid-ant 2024-03-26 06:19:25 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
support/v0.42
support/v0.38
support/v0.37
support/v0.36
support/v0.34
support/v0.30
support/v0.27
v0.44.0-rc.13
v0.44.0-rc.12
v0.44.0-rc.11
v0.42.16
v0.44.0-rc.10
v0.44.0-rc.9
v0.44.0-rc.8
v0.44.0-rc.7
v0.44.0-rc.6
v0.44.0-rc.5
v0.44.0-rc.4
v0.44.0-rc.3
v0.44.0-rc.2
v0.44.0-rc.1
v0.43.2
v0.43.1
v0.43.0
v0.42.15
v0.42.14
v0.42.13
v0.42.12
v0.42.11
v0.42.10
v0.42.9
v0.42.8
v0.42.7
v0.42.6
v0.42.5
v0.42.4
v0.42.3
v0.42.2
v0.42.1
v0.42.0
v0.42.0-rc.9
v0.42.0-rc.8
v0.42.0-rc.7
v0.38.9
v0.42.0-rc.6
v0.42.0-rc.5
v0.42.0-rc.4
v0.42.0-rc.3
v0.42.0-rc.2
v0.42.0-rc.1
v0.38.8
v0.41.0
v0.38.7
v0.40.0
v0.39.0
v0.38.6
v0.38.5
v0.38.4
v0.38.3
v0.38.2
v0.38.1
v0.38.0
v0.38.0-rc.2
v0.38.0-rc.1
v0.37.0
v0.37.0-rc.1
v0.36.0
v0.34.0
v0.22.1
v0.22.0
v0.21.1
v0.21.0
v0.20.0
v0.19.0
v0.18.0
v0.17.0
v0.16.0
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.14.0-rc.1
v0.13.2
v0.13.1
v0.13.0
v0.13.0-rc.1
v0.12.1
v0.12.0
v0.12.0-rc3
v0.12.0-rc2
v0.12.0-rc1
v0.11.0
v0.10.0
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
elebedeva
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1055
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?