Makefile: fix target locode-download #1056

elebedeva · 2024-03-26T11:12:00Z

elebedeva commented

2024-03-26 11:12:00 +00:00

wget in target locode-download fails if .cache dir does not exist.
Added check for .cache presence.

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

`wget` in target `locode-download` fails if `.cache` dir does not exist. Added check for `.cache` presence. Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva requested review from storage-core-committers 2024-03-26 11:12:15 +00:00

elebedeva requested review from storage-core-developers 2024-03-26 11:12:18 +00:00

acid-ant commented

2024-03-26 11:24:26 +00:00

Please fix commit header.

👍 1

fyrchik reviewed 2024-03-26 11:49:44 +00:00

Makefile Outdated

					
				@ -265,6 +265,9 @@ debclean:

				# Download locode database

				locode-download:

					if [ ! -d ".cache"]; then \

fyrchik commented

2024-03-26 11:49:44 +00:00

mkdir has -p option which serves this purpose (ignore EEXIST), among others.
Also, while we are here: it seems that .cache is actually $(TMP_DIR) -- can we use it (see other targets, should be similar to this one).

`mkdir` has `-p` option which serves this purpose (ignore EEXIST), among others. Also, while we are here: it seems that `.cache` is actually `$(TMP_DIR)` -- can we use it (see other targets, should be similar to this one).

elebedeva commented

2024-03-28 12:09:10 +00:00

Replaced condition with mkdir -p and .cache with $(TMP_DIR).

Should I replace .cache with $(TMP_DIR) in other targets as well?

Replaced condition with ```mkdir -p``` and ```.cache``` with ```$(TMP_DIR)```. Should I replace ```.cache``` with ```$(TMP_DIR)``` in other targets as well?