netmap: Do not iterate over external addresses in Node #1057

fyrchik · 2024-03-27T12:21:26Z

fyrchik commented

2024-03-27 12:21:26 +00:00

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik added 1 commit 2024-03-27 12:21:28 +00:00

Vulncheck / Vulncheck (pull_request) Successful in 2m24s Details

Tests and linters / Staticcheck (pull_request) Successful in 4m36s Details

DCO action / DCO (pull_request) Failing after 6m58s Details

Build / Build Components (1.21) (pull_request) Successful in 7m39s Details

Build / Build Components (1.20) (pull_request) Successful in 11m19s Details

Tests and linters / gopls check (pull_request) Successful in 11m5s Details

Tests and linters / Tests (1.21) (pull_request) Successful in 12m2s Details

Tests and linters / Tests with -race (pull_request) Successful in 16m46s Details

Tests and linters / Tests (1.20) (pull_request) Successful in 18m32s Details

Tests and linters / Lint (pull_request) Successful in 19m2s Details

b5d5517c1c netmap: Do not iterate over external addresses in Node

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-committers 2024-03-27 12:21:50 +00:00

fyrchik requested review from storage-core-developers 2024-03-27 12:21:50 +00:00

fyrchik force-pushed fix-external-addr from b5d5517c1c to 1ecb251b9e

2024-03-27 12:22:11 +00:00

Compare

acid-ant approved these changes 2024-03-27 12:30:51 +00:00

aarifullin reviewed 2024-03-28 10:27:50 +00:00

pkg/core/netmap/nodes.go

													
				@ -18,11 +18,6 @@ func (x Node) PublicKey() []byte {

				// and passes them into f. Handler MUST NOT be nil.

				func (x Node) IterateAddresses(f func(string) bool) {

					(netmap.NodeInfo)(x).IterateNetworkEndpoints(f)

					for _, addr := range (netmap.NodeInfo)(x).ExternalAddresses() {

aarifullin commented

2024-03-28 10:27:50 +00:00

Could you explain, please, why?

fyrchik commented

2024-03-28 14:39:00 +00:00

Poster

This wrapper still contains ExternalAddresses field, which is used in places where we need them.
In IterateAddresses only internal are expected.
Though, this line was here from the initial implementation

This wrapper still contains `ExternalAddresses` field, which is used in places where we need them. In `IterateAddresses` only internal are expected. Though, this line was here from the initial implementation