TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

node, ir, morph: Add new config option upgrade_mode #1072

Merged
fyrchik merged 3 commits from acid-ant/frostfs-node:bugfix/upgrade-flag into master 2024-04-08 08:31:03 +00:00
Conversation 1 Commits 3 Files Changed 10
acid-ant commented 2024-04-03 09:20:25 +00:00
Collaborator

Set scope None for notary cosigners when node in upgrade mode.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Set scope `None` for notary cosigners when node in upgrade mode. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant added 3 commits 2024-04-03 09:20:27 +00:00
8773e8468d [#xx] Fix gofumpt issue 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
9c7eebbe27 [#xx] node, ir: Add new config option `upgrade_mode` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
DCO action / DCO (pull_request) Failing after 1m20s Details
Vulncheck / Vulncheck (pull_request) Successful in 3m32s Details
Build / Build Components (1.21) (pull_request) Successful in 5m6s Details
Build / Build Components (1.20) (pull_request) Successful in 5m15s Details
Tests and linters / Staticcheck (pull_request) Successful in 6m0s Details
Tests and linters / gopls check (pull_request) Successful in 6m3s Details
Tests and linters / Lint (pull_request) Successful in 6m40s Details
Tests and linters / Tests with -race (pull_request) Successful in 7m21s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 8m41s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 8m48s Details
cd9fa1751a [#xx] node, ir, morph: Set scope `None` when in upgrade mode 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant changed title from node, ir, morph: Add new config option `upgrade_mode` to WIP: node, ir, morph: Add new config option `upgrade_mode` 2024-04-03 09:21:25 +00:00
acid-ant force-pushed bugfix/upgrade-flag from cd9fa1751a to 0d798fb33e 2024-04-03 09:51:56 +00:00 Compare
acid-ant force-pushed bugfix/upgrade-flag from 0d798fb33e to 6543b68144 2024-04-03 10:54:12 +00:00 Compare
acid-ant changed title from WIP: node, ir, morph: Add new config option `upgrade_mode` to node, ir, morph: Add new config option `upgrade_mode` 2024-04-03 10:54:43 +00:00
acid-ant requested review from storage-core-committers 2024-04-03 10:54:50 +00:00
acid-ant requested review from storage-core-developers 2024-04-03 10:54:51 +00:00
dstepanov-yadro approved these changes 2024-04-03 12:40:22 +00:00
fyrchik requested changes 2024-04-03 13:22:40 +00:00
cmd/frostfs-node/config.go Outdated
@ -111,1 +107,4 @@
}
// is node in the upgrade mode
isUpgrade *bool
fyrchik commented 2024-04-03 13:04:05 +00:00
Owner

Maybe there is no data race (hard do check, honestly), but what prevents us from using atomic right away?

Maybe there is no data race (hard do check, honestly), but what prevents us from using atomic right away?
acid-ant commented 2024-04-03 19:41:33 +00:00
Poster
Collaborator

Thought that here it is redundant, but I don't mind using it.

Thought that here it is redundant, but I don't mind using it.
config/example/ir.yaml Outdated
@ -41,6 +41,7 @@ governance:
node:
persistent_state:
path: .frostfs-ir-state # Path to application state file
upgrade_mode: false # Indicates that node is in upgrade mode
fyrchik commented 2024-04-03 13:20:52 +00:00
Owner

More like compatibility_mode (upgrade is a verb and suggests we upgrade something in node)
And can we make it have kludge_ prefix?

More like `compatibility_mode` (`upgrade` is a verb and suggests we upgrade something in node) And can we make it have `kludge_` prefix?
acid-ant commented 2024-04-03 19:42:02 +00:00
Poster
Collaborator

Renamed to node.kludge_compatibility_mode.

Renamed to `node.kludge_compatibility_mode`.
fyrchik marked this conversation as resolved
config/example/node.json Outdated
@ -47,2 +47,3 @@
"ca": "/ca/path"
}
},
"upgrade_mode": false
fyrchik commented 2024-04-03 13:21:00 +00:00
Owner

Do we need this in node?

Do we need this in node?
fyrchik commented 2024-04-03 13:21:03 +00:00
Owner

Do we need this in node?

Do we need this in node?
acid-ant commented 2024-04-03 19:45:46 +00:00
Poster
Collaborator

Removed this option from description. If you are asking about do we need to run node in compatibility mode too - I thought yes.

Removed this option from description. If you are asking about do we need to run `node` in compatibility mode too - I thought yes.
acid-ant force-pushed bugfix/upgrade-flag from 6543b68144 to 32aef896e9 2024-04-03 19:39:35 +00:00 Compare
acid-ant force-pushed bugfix/upgrade-flag from 32aef896e9 to ebb3ba5204 2024-04-04 08:18:34 +00:00 Compare
acid-ant commented 2024-04-04 08:21:20 +00:00
Poster
Collaborator

Revert changes related to refactoring of applicationConfiguration.readConfig().

Revert changes related to refactoring of `applicationConfiguration.readConfig()`.
fyrchik approved these changes 2024-04-04 08:25:31 +00:00
acid-ant added 1 commit 2024-04-04 08:37:22 +00:00
Build / Build Components (1.20) (pull_request) Successful in 2m20s Details
Build / Build Components (1.21) (pull_request) Successful in 5m11s Details
DCO action / DCO (pull_request) Failing after 5m26s Details
Tests and linters / Lint (pull_request) Successful in 7m22s Details
Tests and linters / Staticcheck (pull_request) Successful in 7m8s Details
Tests and linters / gopls check (pull_request) Successful in 8m55s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 15m35s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 15m42s Details
Tests and linters / Tests with -race (pull_request) Successful in 15m36s Details
Vulncheck / Vulncheck (pull_request) Failing after 1m14s Details
26d50f31c4 [#1072] Fix issue from `govulncheck` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
fyrchik referenced this issue from a commit 2024-04-04 10:14:55 +00:00
[#1072] Fix gofumpt issues
fyrchik reviewed 2024-04-05 13:42:24 +00:00
pkg/morph/client/notary.go Outdated
@ -569,0 +570,4 @@
// We must be able to call NNS contract indirectly from the Container contract.
// Thus, CalledByEntry is not sufficient.
// In future we may restrict this to all the usecases we have.
scopes := transaction.Global
fyrchik commented 2024-04-05 13:42:24 +00:00
Owner

I would argue that we do not need this in master, this is useful for 0.37 -- 0.38 upgrade, would be useless for 0.38--0.39

I would argue that we do not need this in master, this is useful for 0.37 -- 0.38 upgrade, would be useless for 0.38--0.39
acid-ant commented 2024-04-05 15:21:07 +00:00
Poster
Collaborator

Absolutely agree. Removed this commit at all.

Absolutely agree. Removed this commit at all.
acid-ant force-pushed bugfix/upgrade-flag from 26d50f31c4 to ffb1a6f81a 2024-04-05 15:20:37 +00:00 Compare
fyrchik approved these changes 2024-04-08 08:30:27 +00:00
fyrchik merged commit ffb1a6f81a into master 2024-04-08 08:31:03 +00:00
fyrchik referenced this issue from a commit 2024-04-08 08:31:07 +00:00
[#1072] Fix gofumpt issues
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1072
There is no content yet.
Delete Branch "acid-ant/frostfs-node:bugfix/upgrade-flag"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?