Performance improvements to support/v0.38 #1084

dstepanov-yadro · 2024-04-09T15:57:23Z

dstepanov-yadro commented

2024-04-09 15:57:23 +00:00

Copy of #1080

Copy of https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1080

dstepanov-yadro added 4 commits 2024-04-09 15:57:25 +00:00

4b902be81e [#1080 ] ape: Do not read object headers before Head/Get

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

7809928b64 [#1080 ] ape: Use value for APE request

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

a8faeb486c [#1080 ] metabase: Open bucket for container counter once

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

Vulncheck / Vulncheck (pull_request) Successful in 1m25s Details

Build / Build Components (1.20) (pull_request) Successful in 2m27s Details

DCO action / DCO (pull_request) Successful in 2m17s Details

Build / Build Components (1.21) (pull_request) Successful in 4m35s Details

Tests and linters / Lint (pull_request) Successful in 10m15s Details

Tests and linters / gopls check (pull_request) Successful in 10m40s Details

Tests and linters / Staticcheck (pull_request) Successful in 11m24s Details

Tests and linters / Tests (1.20) (pull_request) Successful in 13m37s Details

Tests and linters / Tests (1.21) (pull_request) Successful in 13m48s Details

Tests and linters / Tests with -race (pull_request) Successful in 13m54s Details

2571628e30 [#1080 ] metabase: Add StorageID metric

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

dstepanov-yadro requested review from storage-core-committers 2024-04-09 15:57:33 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-04-09 15:57:34 +00:00

acid-ant approved these changes 2024-04-09 18:23:12 +00:00

fyrchik reviewed 2024-04-10 06:56:04 +00:00

pkg/local_object_storage/metabase/counter.go Outdated

													
				@ -236,3 +241,3 @@

						return fmt.Errorf("could not increase phy object counter: %w", err)

					}

					if err := db.updateShardObjectCounter(tx, logical, 1, true); err != nil {

					if err := db.updateShardObjectCounterBucket(b, logical, 1, true); err != nil {

fyrchik commented

2024-04-10 06:56:04 +00:00

The behavious seems to have changed:
Previously we visited these 2 functions and then also went to db.incContainerObjectCounter
Now we skip the last function (it is unchanged by PR, so I suppose it uses different bucket)

The behavious seems to have changed: Previously we visited these 2 functions and then also went to `db.incContainerObjectCounter` Now we skip the last function (it is unchanged by PR, so I suppose it uses different bucket)

dstepanov-yadro commented

2024-04-10 07:02:15 +00:00

Poster

fixed

fyrchik marked this conversation as resolved

dstepanov-yadro force-pushed fix/perf_imporvements_v0.38 from 2571628e30 to 1eb47ab2ce

2024-04-10 07:01:24 +00:00

Compare

fyrchik approved these changes 2024-04-10 07:02:10 +00:00

fyrchik added this to the v0.38.4 milestone 2024-04-10 07:02:37 +00:00

fyrchik merged commit 1eb47ab2ce into support/v0.38

2024-04-10 07:18:10 +00:00