TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 95 Pull Requests 7 Actions Releases Activity

Allow to use user/group targets from the policy contract #1095

Merged
fyrchik merged 5 commits from fyrchik/frostfs-node:policy-user into master 2024-04-16 11:03:54 +00:00
Conversation 0 Commits 5 Files Changed 15
fyrchik commented 2024-04-15 07:48:49 +00:00
Owner

Port #1089
Also, extend support in CLI

Port #1089 Also, extend support in CLI
fyrchik added 4 commits 2024-04-15 07:48:54 +00:00
0719cba058 [#1089] ape: Provide request actor as an additional target 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
99d89715c7 [#1089] control: Format proto files with clang-format 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
7b5d2c2a76 [#1089] control: Add USER and GROUP targets for local override storage 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Tests and linters / Staticcheck (pull_request) Successful in 9m1s Details
Tests and linters / gopls check (pull_request) Successful in 9m36s Details
DCO action / DCO (pull_request) Failing after 10m58s Details
Build / Build Components (1.22) (pull_request) Successful in 12m28s Details
Build / Build Components (1.21) (pull_request) Successful in 12m44s Details
Vulncheck / Vulncheck (pull_request) Successful in 12m49s Details
Tests and linters / Lint (pull_request) Successful in 14m16s Details
Tests and linters / Tests (1.21) (pull_request) Failing after 16m37s Details
Tests and linters / Tests (1.22) (pull_request) Failing after 16m43s Details
Tests and linters / Tests with -race (pull_request) Failing after 16m56s Details
041c0fe783 cli: Support user/group target for local overrides 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added this to the v0.39.0 milestone 2024-04-15 07:48:58 +00:00
fyrchik requested review from storage-core-committers 2024-04-15 07:49:03 +00:00
fyrchik requested review from storage-core-developers 2024-04-15 07:49:06 +00:00
fyrchik force-pushed policy-user from 041c0fe783 to 19277ac906 2024-04-15 07:49:36 +00:00 Compare
acid-ant approved these changes 2024-04-15 08:15:06 +00:00
aarifullin approved these changes 2024-04-16 09:45:16 +00:00
aarifullin left a comment
Collaborator

That looks okay to me

That looks okay to me
aarifullin reviewed 2024-04-16 09:48:54 +00:00
cmd/frostfs-cli/modules/control/list_rules.go
@ -66,6 +68,16 @@ func parseTarget(cmd *cobra.Command) *control.ChainTarget {
Name: name,
Type: control.ChainTarget_CONTAINER,
}
case userTarget:
aarifullin commented 2024-04-16 09:48:54 +00:00
Collaborator

That's nice. But could you also, please, add this for frostfs-adm:
https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/cmd/frostfs-adm/internal/modules/morph/ape/ape_util.go#L38-L47

That's nice. But could you also, please, add this for `frostfs-adm`: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/cmd/frostfs-adm/internal/modules/morph/ape/ape_util.go#L38-L47
fyrchik commented 2024-04-16 10:20:47 +00:00
Poster
Owner

Fixed

Fixed
fyrchik added 1 commit 2024-04-16 10:21:04 +00:00
Build / Build Components (1.21) (pull_request) Successful in 1m36s Details
DCO action / DCO (pull_request) Failing after 3m14s Details
Vulncheck / Vulncheck (pull_request) Successful in 3m5s Details
Build / Build Components (1.22) (pull_request) Successful in 3m53s Details
Tests and linters / Staticcheck (pull_request) Successful in 4m33s Details
Tests and linters / gopls check (pull_request) Successful in 4m54s Details
Tests and linters / Lint (pull_request) Successful in 5m39s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 7m44s Details
Tests and linters / Tests with -race (pull_request) Successful in 7m46s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 7m58s Details
95e1822ce1 [#1095] adm: Support user/group target for APE 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
acid-ant approved these changes 2024-04-16 10:46:41 +00:00
fyrchik force-pushed policy-user from 95e1822ce1 to 41093fe36c 2024-04-16 11:03:35 +00:00 Compare
fyrchik merged commit 97e54066d0 into master 2024-04-16 11:03:54 +00:00
fyrchik deleted branch policy-user 2024-04-16 11:03:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.39.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1095
There is no content yet.
Delete Branch "fyrchik/frostfs-node:policy-user"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?