TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

Rename contract-related neofs occurences #11

Merged
fyrchik merged 6 commits from fix-adm into master 2023-01-12 05:55:47 +00:00
Conversation 1 Commits 6 Files Changed 63
fyrchik commented 2023-01-10 13:09:52 +00:00 (Migrated from github.com)

Related TrueCloudLab/frostfs-contract#5

Related TrueCloudLab/frostfs-contract#5
KirillovDenis (Migrated from github.com) reviewed 2023-01-10 13:09:52 +00:00
acid-ant (Migrated from github.com) reviewed 2023-01-10 13:29:21 +00:00
pkg/local_object_storage/pilorama/new
acid-ant (Migrated from github.com) commented 2023-01-10 13:28:43 +00:00

Looks like added by mistake.

Looks like added by mistake.
carpawell (Migrated from github.com) requested changes 2023-01-10 16:17:29 +00:00
cmd/frostfs-adm/internal/modules/morph/internal/types.pb.go
carpawell (Migrated from github.com) commented 2023-01-10 16:13:32 +00:00

Change the orig .pb file instead of the generated one?

Change the orig `.pb` file instead of the generated one?
pkg/local_object_storage/pilorama/new
carpawell (Migrated from github.com) commented 2023-01-10 16:17:23 +00:00

i think, yes

i think, yes
fyrchik (Migrated from github.com) reviewed 2023-01-11 07:44:45 +00:00
pkg/local_object_storage/pilorama/new
fyrchik (Migrated from github.com) commented 2023-01-11 07:44:44 +00:00

Fixed

Fixed
fyrchik (Migrated from github.com) reviewed 2023-01-11 07:44:47 +00:00
cmd/frostfs-adm/internal/modules/morph/internal/types.pb.go
fyrchik (Migrated from github.com) commented 2023-01-11 07:44:47 +00:00

Fixed

Fixed
carpawell (Migrated from github.com) reviewed 2023-01-11 07:53:05 +00:00
acid-ant (Migrated from github.com) reviewed 2023-01-11 08:00:18 +00:00
alexvanin commented 2023-01-11 08:40:59 +00:00 (Migrated from github.com)

Now https://github.com/TrueCloudLab/frostfs-contract/pull/5 renames neofsid to frostfsid so we can change it here too?

Now https://github.com/TrueCloudLab/frostfs-contract/pull/5 renames `neofsid` to `frostfsid` so we can change it here too?
alexvanin (Migrated from github.com) approved these changes 2023-01-11 14:40:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
KirillovDenis
carpawell
alexvanin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#11
There is no content yet.
Delete Branch "fix-adm"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?