Do not log same errors in policer twice #110

Closed
opened 2023-03-08 23:34:36 +00:00 by snegurochka · 2 comments

Original issue: https://github.com/nspcc-dev/neofs-node/issues/1988

Do not log same errors in policer twice. Seems useless, if we cannot select any nodes from the container, it won't change during this epoch.

окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.922Z        error        policer/check.go:98        could not build placement vector for object        {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.922Z        error        policer/check.go:98        could not build placement vector for object        {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z        error        policer/check.go:98        could not build placement vector for object        {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z        error        policer/check.go:98        could not build placement vector for object        {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z        error        policer/check.go:98        could not build placement vector for object        {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z        error        policer/check.go:98        could not build placement vector for object        {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z        error        policer/check.go:98        could not build placement vector for object        {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z        error        policer/check.go:98        could not build placement vector for object        {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
Original issue: https://github.com/nspcc-dev/neofs-node/issues/1988 Do not log same errors in policer twice. Seems useless, if we cannot select any nodes from the container, it won't change during this epoch. ``` окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.922Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"} окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.922Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"} окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"} окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"} окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"} окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"} окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"} окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"} ```
fyrchik added the
enhancement
discussion
frostfs-node
labels 2023-03-23 08:52:56 +00:00
fyrchik added this to the v0.38.0 milestone 2023-05-18 08:35:52 +00:00
fyrchik added the
observability
label 2023-05-18 10:46:07 +00:00

Another option to fix this kind of errors is to ignore container for some time if we cannot build a placement for it.

Another option to fix _this_ kind of errors is to ignore container for some time if we cannot build a placement for it.

Closed via #914

Closed via #914
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#110
There is no content yet.