Investigate unused linter report with field-writes-are-uses setting disabled #1111

elebedeva · 2024-04-27T13:01:33Z

elebedeva commented

2024-04-27 13:01:33 +00:00

The investigation revealed several cases of false-positive results:

Known issue of struct being used as a map key without any field access occurred 3 times:

cmd/frostfs-node/policy_engine.go:28 , 29
pkg/util/locode/table/csv/calls.go:59 , 60
pkg/services/session/storage/temporary/storage.go:12 , 13

Therefore leaving field-writes-are-uses enabled as it is by default.

Removed unnecessary unused fields.

Close #1100 The investigation revealed several cases of false-positive results: 1. Known issue of struct being used as a map key without any field access occurred 3 times: ``` cmd/frostfs-node/policy_engine.go:28 , 29 pkg/util/locode/table/csv/calls.go:59 , 60 pkg/services/session/storage/temporary/storage.go:12 , 13 ``` Therefore leaving `field-writes-are-uses` enabled as it is by default. Removed unnecessary unused fields.

🚀 1

elebedeva added the

internal

label 2024-04-27 13:01:33 +00:00

elebedeva added 2 commits 2024-04-27 13:01:42 +00:00

41795a7d06 [#1100 ] Add usage to `pubKey` field of Server

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

DCO action / DCO (pull_request) Successful in 5m10s Details

Vulncheck / Vulncheck (pull_request) Successful in 6m17s Details

Tests and linters / Lint (pull_request) Successful in 8m41s Details

Build / Build Components (1.22) (pull_request) Successful in 10m50s Details

Build / Build Components (1.21) (pull_request) Successful in 10m55s Details

Tests and linters / gopls check (pull_request) Successful in 11m14s Details

Tests and linters / Staticcheck (pull_request) Successful in 12m31s Details

Tests and linters / Tests (1.22) (pull_request) Successful in 13m25s Details

Tests and linters / Tests (1.21) (pull_request) Successful in 14m12s Details

Tests and linters / Tests with -race (pull_request) Successful in 14m12s Details

e17fc60c13 [#1100 ] Remove unused fields

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva requested review from storage-core-committers 2024-04-27 13:02:02 +00:00

elebedeva requested review from storage-core-developers 2024-04-27 13:02:04 +00:00

acid-ant approved these changes 2024-04-27 13:08:24 +00:00

achuprov approved these changes 2024-04-27 13:21:52 +00:00

fyrchik reviewed 2024-04-27 13:42:33 +00:00

pkg/innerring/innerring.go Outdated

													
				@ -70,3 +70,3 @@

						// internal variables

						key                   *keys.PrivateKey

						pubKey                []byte

						pubKey                *keys.PublicKey

fyrchik commented

2024-04-27 13:42:33 +00:00

Frankly, I would remove it completely, there is no need to cache it, getting public key from the private is free, no calculations required https://pkg.go.dev/crypto/ecdsa#PrivateKey

👍 2

fyrchik commented

2024-04-27 13:46:51 +00:00

even more so, we now have 2 different sources for public key, which can diverge in future

even more so, we now have 2 different sources for public key, which _can_ diverge in future

fyrchik commented

2024-05-02 11:28:32 +00:00

raw bytes made sense, when it was marshaled a lot, to reduce allocations