Add EC APE check #1125

dstepanov-yadro · 2024-05-08T07:24:39Z

dstepanov-yadro commented

2024-05-08 07:24:39 +00:00

For operations on EC chunks on container nodes for requests not from container or IR, EC parent headers will be used.

dstepanov-yadro force-pushed feat/ec_ape from f4965e92c9 to b3189b5616

2024-05-08 07:26:49 +00:00

Compare

aarifullin reviewed 2024-05-08 08:15:04 +00:00

pkg/services/object/ape/request.go Outdated

					
				@ -139,0 +169,4 @@

					return parentObj.ToV2().GetHeader()

				}

				func (c *checkerImpl) currentNodeIsContainerNode(cnrID cid.ID) (bool, error) {

aarifullin commented

2024-05-08 08:15:04 +00:00

I suppose you have considered this step to avoid extra iterations over local shards (we don't need to iterate over shard if it's not container - it will find nothing). Could you, please, to add explanatory comment before/after

contNode, err := c.currentNodeIsContainerNode(prm.Container)
if err != nil || !contNode {
   return header
}

I suppose you have considered this step to avoid extra iterations over local shards (we don't need to iterate over shard if it's not container - it will find nothing). Could you, please, to add explanatory comment before/after ```go contNode, err := c.currentNodeIsContainerNode(prm.Container) if err != nil || !contNode { return header } ```

dstepanov-yadro commented

2024-05-08 08:20:31 +00:00

The reason is different, but commend added.

👍 1

aarifullin marked this conversation as resolved

dstepanov-yadro force-pushed feat/ec_ape from b3189b5616 to 766c4fc647

2024-05-08 08:20:23 +00:00

Compare

dstepanov-yadro force-pushed feat/ec_ape from 766c4fc647 to bac5b9db32

2024-05-08 08:21:18 +00:00

Compare

dstepanov-yadro force-pushed feat/ec_ape from bac5b9db32 to 68e0e89a8a