TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

node: Move SignMessage to separate package #1132

Merged
fyrchik merged 1 commit from achuprov/frostfs-node:feat/move_SignMessage into master 2024-05-16 10:35:49 +00:00
Conversation 1 Commits 1 Files changed 17 +86 -65
achuprov commented 2024-05-14 14:23:31 +00:00
Member
Copy link

Close #1092

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #1092 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from storage-core-committers 2024-05-14 14:23:48 +00:00
achuprov requested review from storage-core-developers 2024-05-14 14:23:51 +00:00
achuprov requested review from alexvanin 2024-05-14 14:24:21 +00:00
fyrchik reviewed 2024-05-14 14:26:31 +00:00
pkg/services/control/server/message/sign.go Outdated
@ -0,0 +1,44 @@
package message
fyrchik commented 2024-05-14 14:26:13 +00:00
Owner
Copy link

I would also avoid such a generic name, how about ctrlmessage (it uses signature type from protodefs of the control service).

I would also avoid such a generic name, how about `ctrlmessage` (it uses signature type from protodefs of the control service).
pkg/services/control/server/message/sign.go Outdated
@ -0,0 +17,4 @@
}
// SignMessage signs Control service message with private key.
func SignMessage(key *ecdsa.PrivateKey, msg SignedMessage) error {
fyrchik commented 2024-05-14 14:25:29 +00:00
Owner
Copy link

Should be Sign, so that caller has message.Sign

Should be `Sign`, so that caller has `message.Sign`
👍 1
achuprov force-pushed feat/move_SignMessage from a5ea01f5ad to e562f33042 2024-05-14 14:43:27 +00:00 Compare
fyrchik approved these changes 2024-05-14 15:09:54 +00:00
pkg/services/control/server/message/sign.go Outdated
@ -0,0 +1,44 @@
package ctrlmessage
fyrchik commented 2024-05-14 15:09:51 +00:00
Owner
Copy link

Can we also rename the directory?

Can we also rename the directory?
fyrchik marked this conversation as resolved
fyrchik commented 2024-05-15 12:31:29 +00:00
Owner
Copy link

Please, take a look at the commit message too, it seems SignMessage is missing.
The component is also control, not node

Please, take a look at the commit message too, it seems `SignMessage` is missing. The component is also `control`, not `node`
achuprov force-pushed feat/move_SignMessage from e562f33042 to 4e9c91fc3e 2024-05-16 09:13:49 +00:00 Compare
achuprov force-pushed feat/move_SignMessage from 4e9c91fc3e to b078fe5ba1 2024-05-16 09:14:21 +00:00 Compare
fyrchik merged commit b078fe5ba1 into master 2024-05-16 10:35:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1132
No description provided.
Delete branch "achuprov/frostfs-node:feat/move_SignMessage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?