TrueCloudLab/frostfs-node
17
1
Fork 22
Code Issues 97 Pull requests 5 Projects Releases 1 Activity Actions

shard: Set Disabled as default mode for components #1168

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/shard-create-mode-cmp into master 2024-06-11 15:13:43 +00:00
Conversation 0 Commits 1 Files changed 4 +4 -1
acid-ant commented 2024-06-07 12:57:27 +00:00
Member
Copy link

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant force-pushed bugfix/shard-create-mode-cmp from c217699e2a to b3b0a0dade 2024-06-07 12:59:09 +00:00 Compare
acid-ant force-pushed bugfix/shard-create-mode-cmp from b3b0a0dade to e31104c9c9 2024-06-07 12:59:53 +00:00 Compare
acid-ant requested review from storage-core-committers 2024-06-07 13:10:05 +00:00
acid-ant requested review from storage-core-developers 2024-06-07 13:10:13 +00:00
achuprov approved these changes 2024-06-07 14:36:04 +00:00
dstepanov-yadro approved these changes 2024-06-07 14:44:37 +00:00
fyrchik reviewed 2024-06-09 18:34:37 +00:00
pkg/local_object_storage/writecache/options.go Outdated
@ -57,0 +60,4 @@
// WithMode sets mode.
func WithMode(mode mode.Mode) Option {
return func(o *options) {
o.mode = mode
fyrchik commented 2024-06-09 18:34:29 +00:00
Owner
Copy link

Why is it important if we already provide the mode in Open?

Why is it important if we already provide the mode in `Open`?
acid-ant commented 2024-06-10 05:50:34 +00:00
Author
Member
Copy link

Because in degraded scenario, we skip Open and Init for write-cache, my fault.

Because in degraded scenario, we skip [Open](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/a0c588263bd550bb131a8ed2f1a5ad318811018c/pkg/local_object_storage/shard/control.go#L58) and [Init](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/a0c588263bd550bb131a8ed2f1a5ad318811018c/pkg/local_object_storage/shard/control.go#L125) for write-cache, my fault.
fyrchik commented 2024-06-10 07:31:33 +00:00
Owner
Copy link

I think default values should be usable (and "degraded" mode being the default for write-cache is accidental).
What about using disabled for everything and change this mode on Open? It seems logical.

I think default values should be usable (and "degraded" mode being the default for write-cache is accidental). What about using `disabled` for everything and change this mode on `Open`? It seems logical.
acid-ant commented 2024-06-10 14:50:54 +00:00
Author
Member
Copy link

Sounds better. Updated.

Sounds better. Updated.
acid-ant force-pushed bugfix/shard-create-mode-cmp from e31104c9c9 to b71675add6 2024-06-10 14:49:34 +00:00 Compare
acid-ant changed title from shard: Set `mode` for components when created to shard: Set `Disabled` as default `mode` for components 2024-06-10 14:50:01 +00:00
acid-ant requested review from achuprov 2024-06-10 14:50:24 +00:00
acid-ant requested review from dstepanov-yadro 2024-06-10 14:50:25 +00:00
acid-ant force-pushed bugfix/shard-create-mode-cmp from b71675add6 to e7e3bbbc25 2024-06-10 14:52:45 +00:00 Compare
fyrchik approved these changes 2024-06-10 15:01:33 +00:00
achuprov approved these changes 2024-06-11 07:31:00 +00:00
fyrchik merged commit b9fcaad21f into master 2024-06-11 15:13:43 +00:00
fyrchik added this to the v0.41.0 milestone 2024-06-14 07:00:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
achuprov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.41.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1168
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/shard-create-mode-cmp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?